third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationInspectorAgent.cpp - Issue 1702673002: DevTools: migrate remote debugging protocol generators to jinja2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationInspectorAgent.cpp

Issue 1702673002: DevTools: migrate remote debugging protocol generators to jinja2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp ('K') | « third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp ('k') | third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.h » ('j') | third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationInspectorAgent.cpp

diff --git a/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationInspectorAgent.cpp b/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationInspectorAgent.cpp

index 09968b9da447d7c977d726f11fb69271a8f93513..1af62214d5149821f810e2f26d01ff21d7257bcb 100644

--- a/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationInspectorAgent.cpp

+++ b/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationInspectorAgent.cpp

@@ -21,13 +21,13 @@ namespace {

WebScreenOrientationType WebScreenOrientationTypeFromString(const String& type)

{

- if (type == protocol::TypeBuilder::getEnumConstantValue(protocol::TypeBuilder::ScreenOrientation::OrientationType::PortraitPrimary))

+ if (type == protocol::TypeBuilder::ScreenOrientation::OrientationTypeEnum::PortraitPrimary)

return WebScreenOrientationPortraitPrimary;

- if (type == protocol::TypeBuilder::getEnumConstantValue(protocol::TypeBuilder::ScreenOrientation::OrientationType::PortraitSecondary))

+ if (type == protocol::TypeBuilder::ScreenOrientation::OrientationTypeEnum::PortraitSecondary)

return WebScreenOrientationPortraitSecondary;

- if (type == protocol::TypeBuilder::getEnumConstantValue(protocol::TypeBuilder::ScreenOrientation::OrientationType::LandscapePrimary))

+ if (type == protocol::TypeBuilder::ScreenOrientation::OrientationTypeEnum::LandscapePrimary)

return WebScreenOrientationLandscapePrimary;

- if (type == protocol::TypeBuilder::getEnumConstantValue(protocol::TypeBuilder::ScreenOrientation::OrientationType::LandscapeSecondary))

+ if (type == protocol::TypeBuilder::ScreenOrientation::OrientationTypeEnum::LandscapeSecondary)

return WebScreenOrientationLandscapeSecondary;

return WebScreenOrientationUndefined;

}