third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h - Issue 1702673002: DevTools: migrate remote debugging protocol generators to jinja2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h

Issue 1702673002: DevTools: migrate remote debugging protocol generators to jinja2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp ('K') | « third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp » ('j') | third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h

diff --git a/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h b/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h

index cc6944d8c337078863569f513619ab953be480d5..80ac9b1b379ca9d9c696ed4f0308fb1d2d2cc151 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h

+++ b/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h

@@ -42,7 +42,7 @@ public:

void disable(ErrorString*) override;

// Protocol method implementations.

- void start(ErrorString*, const String* categoryFilter, const String*, const double*, const String*, PassRefPtr<StartCallback>) override;

+ void start(ErrorString*, const protocol::TypeBuilder::OptionalValue<String>& in_categories, const protocol::TypeBuilder::OptionalValue<String>& in_options, const protocol::TypeBuilder::OptionalValue<double>& in_bufferUsageReportingInterval, const protocol::TypeBuilder::OptionalValue<String>& in_transferMode, PassRefPtr<StartCallback>) override;

void end(ErrorString*, PassRefPtr<EndCallback>) override;

// Methods for other agents to use.