Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(824)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorResourceAgent.h

Issue 1702673002: DevTools: migrate remote debugging protocol generators to jinja2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorResourceAgent.h
diff --git a/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.h b/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.h
index d4a99cb35bbbc901145891ad018a44ef0f9c69b7..692b53d8810a97711bb833bb695b6de5f0e038c1 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.h
+++ b/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.h
@@ -75,7 +75,6 @@ public:
return adoptPtrWillBeNoop(new InspectorResourceAgent(inspectedFrames));
}
- void disable(ErrorString*) override;
void restore() override;
~InspectorResourceAgent() override;
@@ -120,7 +119,7 @@ public:
void frameScheduledNavigation(LocalFrame*, double);
void frameClearedScheduledNavigation(LocalFrame*);
- PassRefPtr<protocol::TypeBuilder::Network::Initiator> buildInitiatorObject(Document*, const FetchInitiatorInfo&);
+ PassOwnPtr<protocol::TypeBuilder::Network::Initiator> buildInitiatorObject(Document*, const FetchInitiatorInfo&);
void didCreateWebSocket(Document*, unsigned long identifier, const KURL& requestURL, const String&);
void willSendWebSocketHandshakeRequest(Document*, unsigned long identifier, const WebSocketHandshakeRequest*);
@@ -132,21 +131,19 @@ public:
// Called from frontend
void enable(ErrorString*) override;
- void setUserAgentOverride(ErrorString*, const String& userAgent) override;
- void setExtraHTTPHeaders(ErrorString*, const RefPtr<JSONObject>&) override;
- void getResponseBody(ErrorString*, const String& requestId, PassRefPtr<GetResponseBodyCallback>) override;
- void addBlockedURL(ErrorString*, const String& url) override;
- void removeBlockedURL(ErrorString*, const String& url) override;
-
- void replayXHR(ErrorString*, const String& requestId) override;
- void setMonitoringXHREnabled(ErrorString*, bool) override;
-
- void canClearBrowserCache(ErrorString*, bool*) override;
- void canClearBrowserCookies(ErrorString*, bool*) override;
- void emulateNetworkConditions(ErrorString*, bool, double, double, double) override;
- void setCacheDisabled(ErrorString*, bool cacheDisabled) override;
-
- void setDataSizeLimitsForTest(ErrorString*, int maxTotal, int maxResource) override;
+ void disable(ErrorString*) override;
+ void setUserAgentOverride(ErrorString*, const String& in_userAgent) override;
+ void setExtraHTTPHeaders(ErrorString*, PassOwnPtr<protocol::TypeBuilder::Network::Headers> in_headers) override;
+ void getResponseBody(ErrorString*, const String& in_requestId, PassRefPtr<GetResponseBodyCallback>) override;
+ void addBlockedURL(ErrorString*, const String& in_url) override;
+ void removeBlockedURL(ErrorString*, const String& in_url) override;
+ void replayXHR(ErrorString*, const String& in_requestId) override;
+ void setMonitoringXHREnabled(ErrorString*, bool in_enabled) override;
+ void canClearBrowserCache(ErrorString*, bool* out_result) override;
+ void canClearBrowserCookies(ErrorString*, bool* out_result) override;
+ void emulateNetworkConditions(ErrorString*, bool in_offline, double in_latency, double in_downloadThroughput, double in_uploadThroughput) override;
+ void setCacheDisabled(ErrorString*, bool in_cacheDisabled) override;
+ void setDataSizeLimitsForTest(ErrorString*, int in_maxTotalSize, int in_maxResourceSize) override;
// Called from other agents.
void setHostId(const String&);
@@ -180,11 +177,11 @@ private:
RefPtrWillBeMember<XHRReplayData> m_pendingXHRReplayData;
- typedef HashMap<String, RefPtr<protocol::TypeBuilder::Network::Initiator>> FrameNavigationInitiatorMap;
+ typedef HashMap<String, OwnPtr<protocol::TypeBuilder::Network::Initiator>> FrameNavigationInitiatorMap;
FrameNavigationInitiatorMap m_frameNavigationInitiatorMap;
// FIXME: InspectorResourceAgent should now be aware of style recalculation.
- RefPtr<protocol::TypeBuilder::Network::Initiator> m_styleRecalculationInitiator;
+ OwnPtr<protocol::TypeBuilder::Network::Initiator> m_styleRecalculationInitiator;
bool m_isRecalculatingStyle;
PersistentHeapHashSetWillBeHeapHashSet<Member<XMLHttpRequest>> m_replayXHRs;

Powered by Google App Engine
This is Rietveld 408576698