Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h

Issue 1702673002: DevTools: migrate remote debugging protocol generators to jinja2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h
diff --git a/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h b/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h
index abbdb05c7928711087d42917f6246f68729f4147..f01022b120da88cd55e0322980651c862679aa04 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h
+++ b/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h
@@ -62,21 +62,17 @@ public:
void clearFrontend() override;
void restore() override;
- void collectGarbage(ErrorString*) override;
-
- void disable(ErrorString*) override;
void enable(ErrorString*) override;
- void startTrackingHeapObjects(ErrorString*, const bool* trackAllocations) override;
- void stopTrackingHeapObjects(ErrorString*, const bool* reportProgress) override;
-
- void takeHeapSnapshot(ErrorString*, const bool* reportProgress) override;
-
- void getObjectByHeapObjectId(ErrorString*, const String& heapSnapshotObjectId, const String* objectGroup, RefPtr<protocol::TypeBuilder::Runtime::RemoteObject>& result) override;
- void addInspectedHeapObject(ErrorString*, const String& inspectedHeapObjectId) override;
- void getHeapObjectId(ErrorString*, const String& objectId, String* heapSnapshotObjectId) override;
-
+ void disable(ErrorString*) override;
+ void startTrackingHeapObjects(ErrorString*, const protocol::TypeBuilder::OptionalValue<bool>& in_trackAllocations) override;
+ void stopTrackingHeapObjects(ErrorString*, const protocol::TypeBuilder::OptionalValue<bool>& in_reportProgress) override;
+ void takeHeapSnapshot(ErrorString*, const protocol::TypeBuilder::OptionalValue<bool>& in_reportProgress) override;
+ void collectGarbage(ErrorString*) override;
+ void getObjectByHeapObjectId(ErrorString*, const String& in_objectId, const protocol::TypeBuilder::OptionalValue<String>& in_objectGroup, OwnPtr<protocol::TypeBuilder::Runtime::RemoteObject>* out_result) override;
+ void addInspectedHeapObject(ErrorString*, const String& in_heapObjectId) override;
+ void getHeapObjectId(ErrorString*, const String& in_objectId, String* out_heapSnapshotObjectId) override;
void startSampling(ErrorString*) override;
- void stopSampling(ErrorString*, RefPtr<protocol::TypeBuilder::HeapProfiler::SamplingHeapProfile>&) override;
+ void stopSampling(ErrorString*, OwnPtr<protocol::TypeBuilder::HeapProfiler::SamplingHeapProfile>* out_profile) override;
private:
class HeapStatsUpdateTask;

Powered by Google App Engine
This is Rietveld 408576698