Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 1702663002: Reland of Make instrumentation_test_apk depend on their apk_under_test. (Closed)

Created:
4 years, 10 months ago by agrieve
Modified:
4 years, 10 months ago
Reviewers:
jbudorick
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@dist-jar
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland #3 of Tweak GN deps of instrumentation apks Reland of https://codereview.chromium.org/1692383002/ This improves build concurrency a little bit. TBR=jbudorick BUG=none Committed: https://crrev.com/6044a028d31c8459afb0a7ef5df5ab99f51a0db4 Cr-Commit-Position: refs/heads/master@{#375669}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M build/android/gyp/write_build_config.py View 1 2 chunks +0 lines, -2 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 1 chunk +1 line, -1 line 0 comments Download
M build/config/android/rules.gni View 1 2 chunks +17 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (7 generated)
agrieve
Created Reland of Make instrumentation_test_apk depend on their apk_under_test.
4 years, 10 months ago (2016-02-16 16:26:22 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1702663002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1702663002/100001
4 years, 10 months ago (2016-02-16 18:15:23 UTC) #4
agrieve
On 2016/02/16 18:15:23, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
4 years, 10 months ago (2016-02-16 19:01:49 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-16 19:43:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1702663002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1702663002/100001
4 years, 10 months ago (2016-02-16 21:29:53 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:100001)
4 years, 10 months ago (2016-02-16 21:39:21 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:55:05 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6044a028d31c8459afb0a7ef5df5ab99f51a0db4
Cr-Commit-Position: refs/heads/master@{#375669}

Powered by Google App Engine
This is Rietveld 408576698