chrome/browser/notifications/notification_permission_context.h - Issue 1702633002: Fix crash due to VisibilityTimerTabHelper not being cancelled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_permission_context.h

Issue 1702633002: Fix crash due to VisibilityTimerTabHelper not being cancelled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/notifications/notification_permission_context.cc » ('j') | chrome/browser/notifications/notification_permission_context.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/notification_permission_context.h

diff --git a/chrome/browser/notifications/notification_permission_context.h b/chrome/browser/notifications/notification_permission_context.h

index 89323a41583f39c37c9a8c0f64273ac13fb9a5a8..5b92b3d48a80913962bd8ea815c21ed5bbc00dc3 100644

--- a/chrome/browser/notifications/notification_permission_context.h

+++ b/chrome/browser/notifications/notification_permission_context.h

@@ -20,6 +20,8 @@ class NotificationPermissionContext : public PermissionContextBase {

// PermissionContextBase implementation.

void ResetPermission(const GURL& requesting_origin,

const GURL& embedder_origin) override;

+ void CancelPermissionRequest(content::WebContents* web_contents,

+ const PermissionRequestID& id) override;

private:

FRIEND_TEST_ALL_PREFIXES(NotificationPermissionContextTest,