Fix crash due to VisibilityTimerTabHelper not being cancelled

chrome/browser/notifications/notification_permission_context_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/notifications/notification_permission_context.h"
 
 #include "base/bind.h"
 #include "base/message_loop/message_loop.h"
 #include "base/test/test_mock_time_task_runner.h"
 #include "base/time/time.h"
@@ skipping 171 matching lines @@
   EXPECT_EQ(1, permission_context.permission_set_count());
   EXPECT_TRUE(permission_context.last_permission_set_persisted());
   EXPECT_EQ(CONTENT_SETTING_BLOCK,
             permission_context.last_permission_set_setting());
   EXPECT_EQ(CONTENT_SETTING_BLOCK,
             permission_context.GetContentSettingFromMap(url, url));
 
   base::MessageLoop::current()->SetTaskRunner(old_task_runner);
 }
 
+// Tests that navigating cancels incognito permission requests without crashing.
+TEST_F(NotificationPermissionContextTest, TestCancelledIncognitoRequest) {
+  TestNotificationPermissionContext permission_context(
+      profile()->GetOffTheRecordProfile());
+  GURL url("https://www.example.com");
+  NavigateAndCommit(url);
+
+  const PermissionRequestID id(web_contents()->GetRenderProcessHost()->GetID(),
+                               web_contents()->GetMainFrame()->GetRoutingID(),
+                               -1);
+
+  scoped_refptr<base::SingleThreadTaskRunner> old_task_runner(

[Peter Beverloo, 2016/02/16 15:28:28]

The TestMockTimeTaskRunner is now being instantiated in three places (130-135,
203-208 and 239-244), and removed three times as well.

Let's add a helper method + automatic restore in TearDown() if the
|old_task_runner_| is not NULL?

[johnme, 2016/02/16 18:14:34]

Done.

+      base::MessageLoop::current()->task_runner());
+  scoped_refptr<base::TestMockTimeTaskRunner> task_runner(
+      new base::TestMockTimeTaskRunner(base::Time::Now(),
+                                       base::TimeTicks::Now()));
+  base::MessageLoop::current()->SetTaskRunner(task_runner);
+
+  permission_context.RequestPermission(
+      web_contents(), id, url, true /* user_gesture */, base::Bind(&DoNothing));
+
+  permission_context.CancelPermissionRequest(web_contents(), id);
+
+  task_runner->FastForwardBy(base::TimeDelta::FromDays(1));
+
+  EXPECT_EQ(0, permission_context.permission_set_count());
+  EXPECT_EQ(CONTENT_SETTING_ASK,
+            permission_context.GetContentSettingFromMap(url, url));
+
+  base::MessageLoop::current()->SetTaskRunner(old_task_runner);
+}
+
 // Tests how multiple parallel permission requests get auto-denied in incognito.
 TEST_F(NotificationPermissionContextTest, TestParallelDenyInIncognito) {
   TestNotificationPermissionContext permission_context(
       profile()->GetOffTheRecordProfile());
   GURL url("https://www.example.com");
   NavigateAndCommit(url);
   web_contents()->WasShown();
 
   const PermissionRequestID id0(web_contents()->GetRenderProcessHost()->GetID(),
                                 web_contents()->GetMainFrame()->GetRoutingID(),
@@ skipping 46 matching lines @@
   task_runner->FastForwardBy(base::TimeDelta::FromMilliseconds(2500));
   EXPECT_EQ(2, permission_context.permission_set_count());
   EXPECT_TRUE(permission_context.last_permission_set_persisted());
   EXPECT_EQ(CONTENT_SETTING_BLOCK,
             permission_context.last_permission_set_setting());
   EXPECT_EQ(CONTENT_SETTING_BLOCK,
             permission_context.GetContentSettingFromMap(url, url));
 
   base::MessageLoop::current()->SetTaskRunner(old_task_runner);
 }