Chromium Code Reviews

Issue 1702623002: [runtime] Don't cache the holder_map_ in the LookupIterator, it's faster. (Closed)

Created:
4 years, 10 months ago by Toon Verwaest
Modified:
4 years, 10 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Don't cache the holder_map_ in the LookupIterator, it's faster. BUG= Committed: https://crrev.com/f9cdf9d4ed02f747297f70faf4fb4105ffd3206d Cr-Commit-Position: refs/heads/master@{#34063}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Stats (+47 lines, -78 lines)
M src/lookup.h View 8 chunks +3 lines, -9 lines 0 comments
M src/lookup.cc View 15 chunks +44 lines, -62 lines 0 comments
M src/objects.cc View 1 chunk +0 lines, -7 lines 0 comments

Messages

Total messages: 14 (7 generated)
Toon Verwaest
ptal
4 years, 10 months ago (2016-02-16 14:14:54 UTC) #3
Camillo Bruni
lgtm
4 years, 10 months ago (2016-02-16 14:18:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1702623002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1702623002/40001
4 years, 10 months ago (2016-02-16 14:22:20 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/10157) v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, ...
4 years, 10 months ago (2016-02-16 14:23:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1702623002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1702623002/60001
4 years, 10 months ago (2016-02-17 09:22:38 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 10 months ago (2016-02-17 09:46:44 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 09:47:09 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f9cdf9d4ed02f747297f70faf4fb4105ffd3206d
Cr-Commit-Position: refs/heads/master@{#34063}

Powered by Google App Engine