Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 10 months ago by Camillo Bruni Modified:
4 years, 9 months ago Reviewers:
Toon Verwaest CC:
Michael Achenbach, v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Descriptionreland [js-perf-test] Adding micro benchmarks for for-in and keys patterns.
In order to track certain critical code-patters we will start adding
micro-benchmarks that reflect common requests on http://jsperf.com.
In this first CL a number of property enumeration methods are added,
in the hope to get a clearer picture on future regressions.
BUG=
Committed: https://crrev.com/94f0abf98a1ae61423d88d86a933eef431ae7fef
Cr-Commit-Position: refs/heads/master@{#34425}
Patch Set 1 #
Total comments: 1
Patch Set 2 : addressing nits #Patch Set 3 : fixing sources #Patch Set 4 : reduce reruns for keys test #Patch Set 5 : fixing license date #
Created: 4 years, 9 months ago
Messages
Total messages: 23 (12 generated)
cbruni@chromium.org changed reviewers: + verwaest@chromium.org
PTAL, lots of hackery, lots of pretty.
Description was changed from ========== [js-perf-test] Adding micro benchmarks for for-in and keys patterns. BUG= ========== to ========== [js-perf-test] Adding micro benchmarks for for-in and keys patterns. In order to track certain critical code-patters we will start adding micro-benchmarks that reflect common requests on http://jsperf.com. In this first CL a number of property enumeration methods are added, in the hope to get a clearer picture on future regressions. BUG= ==========
lgtm https://codereview.chromium.org/1702613002/diff/1/test/js-perf-test/Keys/keys.js File test/js-perf-test/Keys/keys.js (right): https://codereview.chromium.org/1702613002/diff/1/test/js-perf-test/Keys/keys... test/js-perf-test/Keys/keys.js:7: if (keyGen === undefined) keyGen = (i) => { return "key" + i } var o = {}; newline before var o = {} at the end.
The CQ bit was checked by cbruni@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1702613002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1702613002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by cbruni@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from verwaest@chromium.org Link to the patchset: https://codereview.chromium.org/1702613002/#ps20001 (title: "addressing nits")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1702613002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1702613002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [js-perf-test] Adding micro benchmarks for for-in and keys patterns. In order to track certain critical code-patters we will start adding micro-benchmarks that reflect common requests on http://jsperf.com. In this first CL a number of property enumeration methods are added, in the hope to get a clearer picture on future regressions. BUG= ========== to ========== [js-perf-test] Adding micro benchmarks for for-in and keys patterns. In order to track certain critical code-patters we will start adding micro-benchmarks that reflect common requests on http://jsperf.com. In this first CL a number of property enumeration methods are added, in the hope to get a clearer picture on future regressions. BUG= Committed: https://crrev.com/b00386f97c1b14c73d45f20692051bbf8a004e58 Cr-Commit-Position: refs/heads/master@{#34364} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/b00386f97c1b14c73d45f20692051bbf8a004e58 Cr-Commit-Position: refs/heads/master@{#34364}
The CQ bit was checked by cbruni@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1702613002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1702613002/60001
Description was changed from ========== [js-perf-test] Adding micro benchmarks for for-in and keys patterns. In order to track certain critical code-patters we will start adding micro-benchmarks that reflect common requests on http://jsperf.com. In this first CL a number of property enumeration methods are added, in the hope to get a clearer picture on future regressions. BUG= Committed: https://crrev.com/b00386f97c1b14c73d45f20692051bbf8a004e58 Cr-Commit-Position: refs/heads/master@{#34364} ========== to ========== reland [js-perf-test] Adding micro benchmarks for for-in and keys patterns. In order to track certain critical code-patters we will start adding micro-benchmarks that reflect common requests on http://jsperf.com. In this first CL a number of property enumeration methods are added, in the hope to get a clearer picture on future regressions. BUG= ==========
The CQ bit was checked by cbruni@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from verwaest@chromium.org Link to the patchset: https://codereview.chromium.org/1702613002/#ps80001 (title: "fixing license date")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1702613002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1702613002/80001
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== reland [js-perf-test] Adding micro benchmarks for for-in and keys patterns. In order to track certain critical code-patters we will start adding micro-benchmarks that reflect common requests on http://jsperf.com. In this first CL a number of property enumeration methods are added, in the hope to get a clearer picture on future regressions. BUG= ========== to ========== reland [js-perf-test] Adding micro benchmarks for for-in and keys patterns. In order to track certain critical code-patters we will start adding micro-benchmarks that reflect common requests on http://jsperf.com. In this first CL a number of property enumeration methods are added, in the hope to get a clearer picture on future regressions. BUG= Committed: https://crrev.com/94f0abf98a1ae61423d88d86a933eef431ae7fef Cr-Commit-Position: refs/heads/master@{#34425} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/94f0abf98a1ae61423d88d86a933eef431ae7fef Cr-Commit-Position: refs/heads/master@{#34425} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
