Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 1702613002: [js-perf-test] Adding micro benchmarks for for-in and keys patterns. (Closed)

Created:
4 years, 10 months ago by Camillo Bruni
Modified:
4 years, 9 months ago
Reviewers:
Toon Verwaest
CC:
Michael Achenbach, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

reland [js-perf-test] Adding micro benchmarks for for-in and keys patterns. In order to track certain critical code-patters we will start adding micro-benchmarks that reflect common requests on http://jsperf.com. In this first CL a number of property enumeration methods are added, in the hope to get a clearer picture on future regressions. BUG= Committed: https://crrev.com/94f0abf98a1ae61423d88d86a933eef431ae7fef Cr-Commit-Position: refs/heads/master@{#34425}

Patch Set 1 #

Total comments: 1

Patch Set 2 : addressing nits #

Patch Set 3 : fixing sources #

Patch Set 4 : reduce reruns for keys test #

Patch Set 5 : fixing license date #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -25 lines) Patch
M test/js-perf-test/JSTests.json View 1 2 3 1 chunk +6 lines, -3 lines 0 comments Download
M test/js-perf-test/Keys/keys.js View 1 2 3 4 9 chunks +22 lines, -21 lines 0 comments Download
M test/js-perf-test/Keys/run.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (12 generated)
Camillo Bruni
PTAL, lots of hackery, lots of pretty.
4 years, 10 months ago (2016-02-16 13:36:41 UTC) #2
Toon Verwaest
lgtm https://codereview.chromium.org/1702613002/diff/1/test/js-perf-test/Keys/keys.js File test/js-perf-test/Keys/keys.js (right): https://codereview.chromium.org/1702613002/diff/1/test/js-perf-test/Keys/keys.js#newcode7 test/js-perf-test/Keys/keys.js:7: if (keyGen === undefined) keyGen = (i) => ...
4 years, 9 months ago (2016-02-29 12:19:08 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1702613002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1702613002/20001
4 years, 9 months ago (2016-02-29 14:18:12 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-02-29 14:36:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1702613002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1702613002/20001
4 years, 9 months ago (2016-02-29 14:52:46 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-02-29 14:54:49 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/b00386f97c1b14c73d45f20692051bbf8a004e58 Cr-Commit-Position: refs/heads/master@{#34364}
4 years, 9 months ago (2016-02-29 14:55:56 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1702613002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1702613002/60001
4 years, 9 months ago (2016-03-02 10:04:45 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1702613002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1702613002/80001
4 years, 9 months ago (2016-03-02 12:07:06 UTC) #20
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 9 months ago (2016-03-02 12:24:42 UTC) #21
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 12:25:50 UTC) #23
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/94f0abf98a1ae61423d88d86a933eef431ae7fef
Cr-Commit-Position: refs/heads/master@{#34425}

Powered by Google App Engine
This is Rietveld 408576698