Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1702533004:
Individually enable and disable SkCodecs (Closed)
DescriptionIndividually enable and disable SkCodecs
BUG=skia:4956
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1702533004
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot
Committed: https://skia.googlesource.com/skia/+/39b2d5a1ac4171aba0e92cb3f9882f62e5730e3e
Patch Set 1 #
Total comments: 5
Patch Set 2 : Add missing WEBP check, disable codecs on Google3 iOS #
Total comments: 6
Patch Set 3 : Only keep the ifdefs that we really need #
Total comments: 16
Patch Set 4 : Remove #ifdef on Jpeg include #Patch Set 5 : Clairfy comments in codec.gyp #Patch Set 6 : #
Messages
Total messages: 39 (18 generated)
Description was changed from ========== Individually enable and disable SkCodecs BUG=skia: ========== to ========== Individually enable and disable SkCodecs BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot ==========
Description was changed from ========== Individually enable and disable SkCodecs BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot ========== to ========== Individually enable and disable SkCodecs BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot ==========
msarett@google.com changed reviewers: + dogben@google.com, mtklein@google.com, scroggo@google.com
I'm on the fence about this... It's a little messy. I think I might explore other options. Let me know what you think. https://codereview.chromium.org/1702533004/diff/1/gyp/codec.gyp File gyp/codec.gyp (left): https://codereview.chromium.org/1702533004/diff/1/gyp/codec.gyp#oldcode25 gyp/codec.gyp:25: 'cflags':[ AFAICT this flag is unnecessary. https://codereview.chromium.org/1702533004/diff/1/public.bzl File public.bzl (left): https://codereview.chromium.org/1702533004/diff/1/public.bzl#oldcode487 public.bzl:487: # TODO(benjaminwagner): Try to get png library updated? INDEX_SUPPORTED is not a feature of a newer libpng. It is a feature of Android's forked libpng (which we have recently removed :)). We intentionally don't support this anymore.
Description was changed from ========== Individually enable and disable SkCodecs BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot ========== to ========== Individually enable and disable SkCodecs BUG=skia:4956 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot ==========
benjaminwagner@google.com changed reviewers: + benjaminwagner@google.com
https://codereview.chromium.org/1702533004/diff/1/public.bzl File public.bzl (right): https://codereview.chromium.org/1702533004/diff/1/public.bzl#newcode502 public.bzl:502: # Turn on image codecs We have removed all dependencies for the iOS Google3 build. Could you add these to DEFINES_UNIX and DEFINES_ANDROID instead?
Description was changed from ========== Individually enable and disable SkCodecs BUG=skia:4956 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot ========== to ========== Individually enable and disable SkCodecs BUG=skia:4956 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot ==========
https://codereview.chromium.org/1702533004/diff/1/public.bzl File public.bzl (right): https://codereview.chromium.org/1702533004/diff/1/public.bzl#newcode502 public.bzl:502: # Turn on image codecs On 2016/02/16 22:31:16, Ben Wagner wrote: > We have removed all dependencies for the iOS Google3 build. Could you add these > to DEFINES_UNIX and DEFINES_ANDROID instead? Yes. Though we should be able to keep BMP and WBMP here, since they have no dependencies. How does this work now? Ex: It seems like JPEG is always enabled, yet there are no libjpegs on iOS?
Patchset #3 (id:40001) has been deleted
Patchset #2 (id:20001) has been deleted
https://codereview.chromium.org/1702533004/diff/60001/tests/CodexTest.cpp File tests/CodexTest.cpp (right): https://codereview.chromium.org/1702533004/diff/60001/tests/CodexTest.cpp#new... tests/CodexTest.cpp:336: #if defined(SK_CODEC_DECODES_WBMP) Thinking about this a little further... Maybe we don't need to clutter our test code with these #ifdefs, since we only test on bots that have the required dependencies. That would make this CL feel a little cleaner. In that case, we can move the defines into codec.gyp.
https://codereview.chromium.org/1702533004/diff/60001/cmake/CMakeLists.txt File cmake/CMakeLists.txt (right): https://codereview.chromium.org/1702533004/diff/60001/cmake/CMakeLists.txt#ne... cmake/CMakeLists.txt:148: # We can always turn on BMP and WBMP codecs. They don't requires any dependencies. Probably no need to guard these with defines then?
If it wasn't clear, I'm a fan of this approach. https://codereview.chromium.org/1702533004/diff/60001/src/codec/SkCodec.cpp File src/codec/SkCodec.cpp (right): https://codereview.chromium.org/1702533004/diff/60001/src/codec/SkCodec.cpp#n... src/codec/SkCodec.cpp:13: #ifdef SK_CODEC_DECODES_BMP You might not need to guard all these headers? IIRC, only SkGifCodec.h had trouble with gif_lib.h wasn't available (and I think we could fix that). https://codereview.chromium.org/1702533004/diff/60001/tests/CodexTest.cpp File tests/CodexTest.cpp (right): https://codereview.chromium.org/1702533004/diff/60001/tests/CodexTest.cpp#new... tests/CodexTest.cpp:336: #if defined(SK_CODEC_DECODES_WBMP) On 2016/02/16 22:52:26, msarett wrote: > Thinking about this a little further... > > Maybe we don't need to clutter our test code with these #ifdefs, since we only > test on bots that have the required dependencies. That would make this CL feel > a little cleaner. > > In that case, we can move the defines into codec.gyp. Agree.
On 2016/02/16 at 22:33:54, msarett wrote: > https://codereview.chromium.org/1702533004/diff/1/public.bzl > File public.bzl (right): > > https://codereview.chromium.org/1702533004/diff/1/public.bzl#newcode502 > public.bzl:502: # Turn on image codecs > On 2016/02/16 22:31:16, Ben Wagner wrote: > > We have removed all dependencies for the iOS Google3 build. Could you add these > > to DEFINES_UNIX and DEFINES_ANDROID instead? > > Yes. Though we should be able to keep BMP and WBMP here, since they have no dependencies. > > How does this work now? Ex: It seems like JPEG is always enabled, yet there are no libjpegs on iOS? All of src/codec is omitted from the build.
I think this version looks much better. https://codereview.chromium.org/1702533004/diff/1/public.bzl File public.bzl (right): https://codereview.chromium.org/1702533004/diff/1/public.bzl#newcode502 public.bzl:502: # Turn on image codecs On 2016/02/16 22:33:54, msarett wrote: > On 2016/02/16 22:31:16, Ben Wagner wrote: > > We have removed all dependencies for the iOS Google3 build. Could you add > these > > to DEFINES_UNIX and DEFINES_ANDROID instead? > > Yes. Though we should be able to keep BMP and WBMP here, since they have no > dependencies. > > How does this work now? Ex: It seems like JPEG is always enabled, yet there are > no libjpegs on iOS? Thanks, removing these on iOS. https://codereview.chromium.org/1702533004/diff/60001/cmake/CMakeLists.txt File cmake/CMakeLists.txt (right): https://codereview.chromium.org/1702533004/diff/60001/cmake/CMakeLists.txt#ne... cmake/CMakeLists.txt:148: # We can always turn on BMP and WBMP codecs. They don't requires any dependencies. On 2016/02/16 23:08:59, mtklein wrote: > Probably no need to guard these with defines then? You're right. Removing these defines. https://codereview.chromium.org/1702533004/diff/60001/src/codec/SkCodec.cpp File src/codec/SkCodec.cpp (right): https://codereview.chromium.org/1702533004/diff/60001/src/codec/SkCodec.cpp#n... src/codec/SkCodec.cpp:13: #ifdef SK_CODEC_DECODES_BMP On 2016/02/16 23:16:01, mtklein wrote: > You might not need to guard all these headers? IIRC, only SkGifCodec.h had > trouble with gif_lib.h wasn't available (and I think we could fix that). Done. Was able to get rid of some but not all of these. https://codereview.chromium.org/1702533004/diff/80001/src/codec/SkCodec.cpp File src/codec/SkCodec.cpp (right): https://codereview.chromium.org/1702533004/diff/80001/src/codec/SkCodec.cpp#n... src/codec/SkCodec.cpp:15: #include "SkJpegCodec.h" Don't think I can get rid of this ifdef. SkJpegUtility_codec.h needs to extend a few structs that are defined in libjpeg. https://codereview.chromium.org/1702533004/diff/80001/src/codec/SkCodec.cpp#n... src/codec/SkCodec.cpp:17: #ifdef SK_CODEC_DECODES_PNG Was almost able to get rid of this ifdef by forward declaring png_structs. The problem is that the names have changed in different versions of libpng (though they are always typedefed to png_structp). https://codereview.chromium.org/1702533004/diff/80001/src/codec/SkJpegCodec.h File src/codec/SkJpegCodec.h (left): https://codereview.chromium.org/1702533004/diff/80001/src/codec/SkJpegCodec.h... src/codec/SkJpegCodec.h:18: extern "C" { Doesn't help much, SkJpegUtility_codec.h includes this anyway.
lgtm https://codereview.chromium.org/1702533004/diff/80001/gyp/codec.gyp File gyp/codec.gyp (left): https://codereview.chromium.org/1702533004/diff/80001/gyp/codec.gyp#oldcode26 gyp/codec.gyp:26: # FIXME: This gets around a longjmp warning. See Did this get fixed in this patch? Or maybe it was fixed before and we didn't notice? Unfortunately that link is no longer valid, but I guess we should see it quickly on the compile bot if we still need it. https://codereview.chromium.org/1702533004/diff/80001/gyp/codec.gyp File gyp/codec.gyp (right): https://codereview.chromium.org/1702533004/diff/80001/gyp/codec.gyp#newcode63 gyp/codec.gyp:63: # Allow the client to turn on/off individual codecs. This can be useful Is the idea that a client would modify this file if they want to disable one? We could add gyp variables that would decide whether to turn them on, like we do for RAW, but if no one needs that, I'm fine to leave as is. https://codereview.chromium.org/1702533004/diff/80001/src/codec/SkAndroidCode... File src/codec/SkAndroidCodec.cpp (right): https://codereview.chromium.org/1702533004/diff/80001/src/codec/SkAndroidCode... src/codec/SkAndroidCodec.cpp:34: case kICO_SkEncodedFormat: I could imagine supporting BMP in ICO even if PNG is not supported, but I don't know that that is worth the effort.
https://codereview.chromium.org/1702533004/diff/80001/src/codec/SkCodec.cpp File src/codec/SkCodec.cpp (right): https://codereview.chromium.org/1702533004/diff/80001/src/codec/SkCodec.cpp#n... src/codec/SkCodec.cpp:15: #include "SkJpegCodec.h" On 2016/02/17 14:34:54, msarett wrote: > Don't think I can get rid of this ifdef. SkJpegUtility_codec.h needs to extend > a few structs that are defined in libjpeg. Are you sure SkJpegCodec.h needs to include SkJpegUtility_codec.h? https://codereview.chromium.org/1702533004/diff/80001/src/codec/SkCodec.cpp#n... src/codec/SkCodec.cpp:17: #ifdef SK_CODEC_DECODES_PNG On 2016/02/17 14:34:54, msarett wrote: > Was almost able to get rid of this ifdef by forward declaring png_structs. The > problem is that the names have changed in different versions of libpng (though > they are always typedefed to png_structp). :/ Sure can't forward declare typedefs. You can, however, do something like this: SkPngCodec.h --------------- class SkPngCodec { public: static bool IsPng(const char*, size_t); static SkCodec* NewFromStream(SkStream*, SkPngChunkReader* = nullptr); }; SkPngCodec.cpp ----------------- namespace { class PngCodec : public SkCodec { .... }; } // namespace SkCodec* SkPngCodec::NewFromStream(...) { return new PngCodec(...); }
https://codereview.chromium.org/1702533004/diff/80001/gyp/codec.gyp File gyp/codec.gyp (right): https://codereview.chromium.org/1702533004/diff/80001/gyp/codec.gyp#newcode63 gyp/codec.gyp:63: # Allow the client to turn on/off individual codecs. This can be useful On 2016/02/17 14:55:55, scroggo wrote: > Is the idea that a client would modify this file if they want to disable one? We > could add gyp variables that would decide whether to turn them on, like we do > for RAW, but if no one needs that, I'm fine to leave as is. Let's not add switches no one's asking to flip yet.
https://codereview.chromium.org/1702533004/diff/80001/gyp/codec.gyp File gyp/codec.gyp (left): https://codereview.chromium.org/1702533004/diff/80001/gyp/codec.gyp#oldcode26 gyp/codec.gyp:26: # FIXME: This gets around a longjmp warning. See On 2016/02/17 14:55:55, scroggo wrote: > Did this get fixed in this patch? Or maybe it was fixed before and we didn't > notice? > > Unfortunately that link is no longer valid, but I guess we should see it quickly > on the compile bot if we still need it. I *think* this was fixed before and we didn't notice. Sorry for the unrelated change. https://codereview.chromium.org/1702533004/diff/80001/gyp/codec.gyp File gyp/codec.gyp (right): https://codereview.chromium.org/1702533004/diff/80001/gyp/codec.gyp#newcode63 gyp/codec.gyp:63: # Allow the client to turn on/off individual codecs. This can be useful On 2016/02/17 14:55:55, scroggo wrote: > Is the idea that a client would modify this file if they want to disable one? We > could add gyp variables that would decide whether to turn them on, like we do > for RAW, but if no one needs that, I'm fine to leave as is. Let's leave as is for now - if we find we need switches later, we can add them. I'm guessing (maybe I'm wrong) that clients who use this build system generally have all the dependencies that we need. This feature is probably more useful for CMake/Google3 clients etc. Maybe the comment is misleading? https://codereview.chromium.org/1702533004/diff/80001/src/codec/SkAndroidCode... File src/codec/SkAndroidCodec.cpp (right): https://codereview.chromium.org/1702533004/diff/80001/src/codec/SkAndroidCode... src/codec/SkAndroidCodec.cpp:34: case kICO_SkEncodedFormat: On 2016/02/17 14:55:55, scroggo wrote: > I could imagine supporting BMP in ICO even if PNG is not supported, but I don't > know that that is worth the effort. I have the same opinion. I think it's fine to wait and see if someone asks for it. https://codereview.chromium.org/1702533004/diff/80001/src/codec/SkCodec.cpp File src/codec/SkCodec.cpp (right): https://codereview.chromium.org/1702533004/diff/80001/src/codec/SkCodec.cpp#n... src/codec/SkCodec.cpp:15: #include "SkJpegCodec.h" On 2016/02/17 14:57:31, mtklein wrote: > On 2016/02/17 14:34:54, msarett wrote: > > Don't think I can get rid of this ifdef. SkJpegUtility_codec.h needs to > extend > > a few structs that are defined in libjpeg. > > Are you sure SkJpegCodec.h needs to include SkJpegUtility_codec.h? Ahh thanks! Removing this. https://codereview.chromium.org/1702533004/diff/80001/src/codec/SkCodec.cpp#n... src/codec/SkCodec.cpp:17: #ifdef SK_CODEC_DECODES_PNG On 2016/02/17 14:57:31, mtklein wrote: > On 2016/02/17 14:34:54, msarett wrote: > > Was almost able to get rid of this ifdef by forward declaring png_structs. > The > > problem is that the names have changed in different versions of libpng (though > > they are always typedefed to png_structp). > > :/ Sure can't forward declare typedefs. > > You can, however, do something like this: > > SkPngCodec.h > --------------- > > class SkPngCodec { > public: > static bool IsPng(const char*, size_t); > static SkCodec* NewFromStream(SkStream*, SkPngChunkReader* = nullptr); > }; > > SkPngCodec.cpp > ----------------- > > namespace { > class PngCodec : public SkCodec { > .... > }; > } // namespace > > SkCodec* SkPngCodec::NewFromStream(...) { return new PngCodec(...); } Gotcha that's cool. I think I prefer this as is though - just to stay consistent with the rest of the codecs.
Still lgtm at patch set 4 https://codereview.chromium.org/1702533004/diff/80001/gyp/codec.gyp File gyp/codec.gyp (right): https://codereview.chromium.org/1702533004/diff/80001/gyp/codec.gyp#newcode63 gyp/codec.gyp:63: # Allow the client to turn on/off individual codecs. This can be useful On 2016/02/17 15:13:47, msarett wrote: > On 2016/02/17 14:55:55, scroggo wrote: > > Is the idea that a client would modify this file if they want to disable one? > We > > could add gyp variables that would decide whether to turn them on, like we do > > for RAW, but if no one needs that, I'm fine to leave as is. > > Let's leave as is for now - if we find we need switches later, we can add them. > > I'm guessing (maybe I'm wrong) that clients who use this build system generally > have all the dependencies that we need. This feature is probably more useful > for CMake/Google3 clients etc. Maybe the comment is misleading? Yes :)
https://codereview.chromium.org/1702533004/diff/80001/gyp/codec.gyp File gyp/codec.gyp (right): https://codereview.chromium.org/1702533004/diff/80001/gyp/codec.gyp#newcode63 gyp/codec.gyp:63: # Allow the client to turn on/off individual codecs. This can be useful On 2016/02/17 15:20:00, scroggo wrote: > On 2016/02/17 15:13:47, msarett wrote: > > On 2016/02/17 14:55:55, scroggo wrote: > > > Is the idea that a client would modify this file if they want to disable > one? > > We > > > could add gyp variables that would decide whether to turn them on, like we > do > > > for RAW, but if no one needs that, I'm fine to leave as is. > > > > Let's leave as is for now - if we find we need switches later, we can add > them. > > > > I'm guessing (maybe I'm wrong) that clients who use this build system > generally > > have all the dependencies that we need. This feature is probably more useful > > for CMake/Google3 clients etc. Maybe the comment is misleading? > > Yes :) Improved this comment.
On 2016/02/17 15:26:28, msarett wrote: > https://codereview.chromium.org/1702533004/diff/80001/gyp/codec.gyp > File gyp/codec.gyp (right): > > https://codereview.chromium.org/1702533004/diff/80001/gyp/codec.gyp#newcode63 > gyp/codec.gyp:63: # Allow the client to turn on/off individual codecs. This can > be useful > On 2016/02/17 15:20:00, scroggo wrote: > > On 2016/02/17 15:13:47, msarett wrote: > > > On 2016/02/17 14:55:55, scroggo wrote: > > > > Is the idea that a client would modify this file if they want to disable > > one? > > > We > > > > could add gyp variables that would decide whether to turn them on, like we > > do > > > > for RAW, but if no one needs that, I'm fine to leave as is. > > > > > > Let's leave as is for now - if we find we need switches later, we can add > > them. > > > > > > I'm guessing (maybe I'm wrong) that clients who use this build system > > generally > > > have all the dependencies that we need. This feature is probably more > useful > > > for CMake/Google3 clients etc. Maybe the comment is misleading? > > > > Yes :) > > Improved this comment. LGTM
The CQ bit was checked by msarett@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1702533004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1702533004/120001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot on client.skia.compile (JOB_FAILED, no build URL)
Description was changed from ========== Individually enable and disable SkCodecs BUG=skia:4956 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot ========== to ========== Individually enable and disable SkCodecs BUG=skia:4956 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot ==========
The CQ bit was checked by msarett@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1702533004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1702533004/120001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)
Description was changed from ========== Individually enable and disable SkCodecs BUG=skia:4956 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot ========== to ========== Individually enable and disable SkCodecs BUG=skia:4956 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot ==========
Description was changed from ========== Individually enable and disable SkCodecs BUG=skia:4956 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot ========== to ========== Individually enable and disable SkCodecs BUG=skia:4956 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot ==========
The CQ bit was checked by msarett@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from scroggo@google.com Link to the patchset: https://codereview.chromium.org/1702533004/#ps140001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1702533004/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1702533004/140001
Message was sent while issue was closed.
Description was changed from ========== Individually enable and disable SkCodecs BUG=skia:4956 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot ========== to ========== Individually enable and disable SkCodecs BUG=skia:4956 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot Committed: https://skia.googlesource.com/skia/+/39b2d5a1ac4171aba0e92cb3f9882f62e5730e3e ==========
Message was sent while issue was closed.
Committed patchset #6 (id:140001) as https://skia.googlesource.com/skia/+/39b2d5a1ac4171aba0e92cb3f9882f62e5730e3e |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
