DevTools: Drop kSinTable dependency off the heap profiler ArrayBuffer backing_store test

DevTools: Drop kSinTable dependency off the heap profiler ArrayBuffer backing_store test

LOG=N
R=dslomov@chromium.org, yurys@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=19458

[alph, 2014-02-18 13:44:16]

ptal

[yurys, 2014-02-18 13:49:09]

lgtm

[Dmitry Lomov (no reviews), 2014-02-18 13:50:43]

lgtm. A small nit a and a question.

https://codereview.chromium.org/170253008/diff/1/test/cctest/test-heap-profil...
File test/cctest/test-heap-profiler.cc (left):

https://codereview.chromium.org/170253008/diff/1/test/cctest/test-heap-profil...
test/cctest/test-heap-profiler.cc:2432: int retainers =
GetRetainersCount(snapshot, backing_store);
Looks like coverage for GetRetainersCount is gone?

https://codereview.chromium.org/170253008/diff/1/test/cctest/test-heap-profil...
File test/cctest/test-heap-profiler.cc (right):

https://codereview.chromium.org/170253008/diff/1/test/cctest/test-heap-profil...
test/cctest/test-heap-profiler.cc:2418: uint8_t* data =
static_cast<uint8_t*>(ab_contents.Data());
Nit: why uint8_t and not void*? Saves you a cast.

[alph, 2014-02-18 15:56:30]

https://codereview.chromium.org/170253008/diff/1/test/cctest/test-heap-profil...
File test/cctest/test-heap-profiler.cc (left):

https://codereview.chromium.org/170253008/diff/1/test/cctest/test-heap-profil...
test/cctest/test-heap-profiler.cc:2432: int retainers =
GetRetainersCount(snapshot, backing_store);
On 2014/02/18 13:50:43, Dmitry Lomov (chromium) wrote:
> Looks like coverage for GetRetainersCount is gone?

Thought it's redundant. Added back.

https://codereview.chromium.org/170253008/diff/1/test/cctest/test-heap-profil...
File test/cctest/test-heap-profiler.cc (right):

https://codereview.chromium.org/170253008/diff/1/test/cctest/test-heap-profil...
test/cctest/test-heap-profiler.cc:2418: uint8_t* data =
static_cast<uint8_t*>(ab_contents.Data());
On 2014/02/18 13:50:43, Dmitry Lomov (chromium) wrote:
> Nit: why uint8_t and not void*? Saves you a cast.

that was a copy-paste. fixed.

[alph, 2014-02-18 15:57:51]

Committed patchset #2 manually as r19458 (presubmit successful).