Make SingleSplitView take borders into account.

SingleSplitView did not take the view border into account when handling the splitter position. This fixes that.

Committed: https://crrev.com/4ee91222d29943b18c56652528a3ee9439ce6237
Cr-Commit-Position: refs/heads/master@{#376876}

[julienp, 2016-02-15 18:40:51]

Description was changed from

==========
Make SingleSplitView take borders into account.
==========

to

==========
SingleSplitView did not take the view border into account when handling the
splitter position. This fixes that.
==========

[julienp, 2016-02-15 18:40:51]

julienp@opera.com changed reviewers:
+ sadrul@chromium.org, sky@chromium.org

[julienp, 2016-02-15 18:50:30]

@sky , @sadrul : Seems like the OWNERS file point to you as reviewers for this
one. Does it look OK to you?

[sky, 2016-02-16 16:33:51]

How about test coverage.

https://codereview.chromium.org/1702473002/diff/1/ui/views/controls/single_sp...
File ui/views/controls/single_split_view.cc (right):

https://codereview.chromium.org/1702473002/diff/1/ui/views/controls/single_sp...
ui/views/controls/single_split_view.cc:92: width +=
border()->GetInsets().width();
border may be null. Use GetInsets().

https://codereview.chromium.org/1702473002/diff/1/ui/views/controls/single_sp...
ui/views/controls/single_split_view.cc:131:
CalculateDividerOffset(divider_offset_, GetContentsBounds(), bounds);
GetContentsBounds() -> bounds

[julienp, 2016-02-17 13:46:26]

I don't think I've seen any existing tests for the SingleSplitView. Did I miss
them?

https://codereview.chromium.org/1702473002/diff/1/ui/views/controls/single_sp...
File ui/views/controls/single_split_view.cc (right):

https://codereview.chromium.org/1702473002/diff/1/ui/views/controls/single_sp...
ui/views/controls/single_split_view.cc:92: width +=
border()->GetInsets().width();
On 2016/02/16 16:33:51, sky wrote:
> border may be null. Use GetInsets().

Done.

https://codereview.chromium.org/1702473002/diff/1/ui/views/controls/single_sp...
ui/views/controls/single_split_view.cc:131:
CalculateDividerOffset(divider_offset_, GetContentsBounds(), bounds);
On 2016/02/16 16:33:51, sky wrote:
> GetContentsBounds() -> bounds

Done.

[sky, 2016-02-17 18:55:18]

https://chromium.googlesource.com/chromium/src/+/master/ui/views/controls/sin...

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[julienp, 2016-02-22 10:14:02]

On 2016/02/17 18:55:18, sky wrote:
>
https://chromium.googlesource.com/chromium/src/+/master/ui/views/controls/sin...
>
I don't know how I even missed that. Anyway, tests have now been taken care of.
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.
>

[sky, 2016-02-22 16:49:04]

LGTM

[julienp, 2016-02-23 00:00:42]

The CQ bit was checked by julienp@opera.com

[commit-bot: I haz the power, 2016-02-23 00:04:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1702473002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1702473002/40001

[commit-bot: I haz the power, 2016-02-23 00:49:15]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-23 00:50:32]

Description was changed from

==========
SingleSplitView did not take the view border into account when handling the
splitter position. This fixes that.
==========

to

==========
SingleSplitView did not take the view border into account when handling the
splitter position. This fixes that.

Committed: https://crrev.com/4ee91222d29943b18c56652528a3ee9439ce6237
Cr-Commit-Position: refs/heads/master@{#376876}
==========

[commit-bot: I haz the power, 2016-02-23 00:50:33]

Patchset 3 (id:??) landed as
https://crrev.com/4ee91222d29943b18c56652528a3ee9439ce6237
Cr-Commit-Position: refs/heads/master@{#376876}