Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1702463002: perf: Remove redirect from mobile site (Closed)

Created:
4 years, 10 months ago by Sami
Modified:
4 years, 10 months ago
Reviewers:
petrcermak
CC:
chromium-reviews, telemetry-reviews_chromium.org, petrcermak
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

perf: Remove redirect from mobile site Remove redirect from the Google Search mobile site because telemetry can't currently correctly pick up interaction records that are emitted via javascript and where a redirect happened during the interaction. (Already reviewed in https://codereview.chromium.org/1697863004/) BUG=540022, 586156 TBR=petrcermak@chromium.org Committed: https://crrev.com/72da02b0ded8c4de4575675d4374e23917bd1e7b Cr-Commit-Position: refs/heads/master@{#375489}

Patch Set 1 #

Patch Set 2 : Fix a couple of other occurances. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M tools/perf/page_sets/data/key_mobile_sites.json View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/data/key_mobile_sites_smooth.json View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/key_mobile_sites.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/key_mobile_sites_smooth.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_memory_multi_tab.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
Sami
(Reuploading under the right account.)
4 years, 10 months ago (2016-02-15 18:27:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1702463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1702463002/1
4 years, 10 months ago (2016-02-15 18:27:22 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/168394)
4 years, 10 months ago (2016-02-15 19:18:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1702463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1702463002/20001
4 years, 10 months ago (2016-02-15 19:43:25 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-15 21:06:48 UTC) #10
petrcermak
LGTM. Thanks, Petr
4 years, 10 months ago (2016-02-16 10:38:58 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:50:47 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/72da02b0ded8c4de4575675d4374e23917bd1e7b
Cr-Commit-Position: refs/heads/master@{#375489}

Powered by Google App Engine
This is Rietveld 408576698