Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Unified Diff: media/mojo/services/mojo_media_application.cc

Issue 1702453002: Revert of Reland "media: Refactor MojoMediaClient" with fix. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: run git cl format media Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/mojo/services/mojo_media_application.h ('k') | media/mojo/services/mojo_media_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/mojo/services/mojo_media_application.cc
diff --git a/media/mojo/services/mojo_media_application.cc b/media/mojo/services/mojo_media_application.cc
index 8a92b022955c756048492fbb7dbe446cac63b61a..05a72f36c21492e89229258c333e5f235a264dfd 100644
--- a/media/mojo/services/mojo_media_application.cc
+++ b/media/mojo/services/mojo_media_application.cc
@@ -12,36 +12,12 @@
#include "mojo/shell/public/cpp/connection.h"
#include "mojo/shell/public/cpp/shell.h"
-#if defined(OS_ANDROID)
-#include "media/mojo/services/android_mojo_media_client.h"
-#else
-#include "media/mojo/services/default_mojo_media_client.h"
-#endif
-
namespace media {
-#if defined(OS_ANDROID)
-using DefaultClient = AndroidMojoMediaClient;
-#else
-using DefaultClient = DefaultMojoMediaClient;
-#endif
-
// static
scoped_ptr<mojo::ShellClient> MojoMediaApplication::CreateApp() {
return scoped_ptr<mojo::ShellClient>(
- new MojoMediaApplication(make_scoped_ptr(new DefaultClient())));
-}
-
-// static
-scoped_ptr<mojo::ShellClient> MojoMediaApplication::CreateAppWithClient(
- const CreateMojoMediaClientCB& create_mojo_media_client_cb) {
- scoped_ptr<MojoMediaClient> mojo_media_client =
- create_mojo_media_client_cb.Run();
- if (!mojo_media_client)
- return nullptr;
-
- return scoped_ptr<mojo::ShellClient>(
- new MojoMediaApplication(std::move(mojo_media_client)));
+ new MojoMediaApplication(MojoMediaClient::Create()));
}
// TODO(xhwang): Hook up MediaLog when possible.
@@ -49,15 +25,13 @@ MojoMediaApplication::MojoMediaApplication(
scoped_ptr<MojoMediaClient> mojo_media_client)
: mojo_media_client_(std::move(mojo_media_client)),
shell_(nullptr),
- media_log_(new MediaLog()) {
- DCHECK(mojo_media_client_);
-}
+ media_log_(new MediaLog()) {}
MojoMediaApplication::~MojoMediaApplication() {}
void MojoMediaApplication::Initialize(mojo::Shell* shell,
- const std::string& /* url */,
- uint32_t /* id */) {
+ const std::string& url,
+ uint32_t id) {
shell_ = shell;
mojo_media_client_->Initialize();
}
« no previous file with comments | « media/mojo/services/mojo_media_application.h ('k') | media/mojo/services/mojo_media_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698