Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 1702453002: Revert of Reland "media: Refactor MojoMediaClient" with fix. (Closed)

Created:
4 years, 10 months ago by hiroshige
Modified:
4 years, 10 months ago
Reviewers:
jam, Nico, xhwang, alokp
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, Peter Beverloo, lcwu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, halliwell+watch_chromium.org, gunsch+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland "media: Refactor MojoMediaClient" with fix. (patchset #2 id:20001 of https://codereview.chromium.org/1690213002/ ) Reason for revert: Suspected to break a layout test on android. https://crbug.com/586902 Original issue's description: > Reland "media: Refactor MojoMediaClient" with fix. > > This reverts commit 29775799918ebeb0f2aedd554722e3db0c6211c2. > > Instead of specifying a platform based MojoMediaClient at compile time, > provide the capability of setting one at run time. This improves the flexibility > of using MojoMediaApplication in different cases. For example, on desktop, we > may want to run the MojoMediaApplication in the utility process (for the CDM > service) and in the GPU process (for hardware decoding). In those two cases, > we'll want to specify two different MojoMediaClients even though we are on the > same platform. > > TBR=alokp@chromium.org > BUG=570357, 571155 TBR=alokp@chromium.org,jam@chromium.org,thakis@chromium.org,xhwang@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=586902, 570357, 571155 Committed: https://crrev.com/55d06b4919b3f310c48dd9520679ca9c338ffca4 Cr-Commit-Position: refs/heads/master@{#375482}

Patch Set 1 #

Patch Set 2 : run git cl format media #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -254 lines) Patch
M chrome/browser/BUILD.gn View 1 1 chunk +2 lines, -4 lines 0 comments Download
M chromecast/browser/cast_content_browser_client.cc View 1 2 chunks +3 lines, -5 lines 0 comments Download
M chromecast/media/mojo/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
D chromecast/media/mojo/cast_mojo_media_client.h View 1 chunk +0 lines, -32 lines 0 comments Download
M chromecast/media/mojo/cast_mojo_media_client.cc View 1 1 chunk +21 lines, -16 lines 0 comments Download
M content/shell/BUILD.gn View 1 1 chunk +2 lines, -2 lines 0 comments Download
M media/mojo/services/BUILD.gn View 1 4 chunks +16 lines, -14 lines 0 comments Download
D media/mojo/services/android_mojo_media_client.h View 1 chunk +0 lines, -28 lines 0 comments Download
M media/mojo/services/android_mojo_media_client.cc View 1 3 chunks +20 lines, -10 lines 0 comments Download
D media/mojo/services/default_mojo_media_client.h View 1 chunk +0 lines, -47 lines 0 comments Download
M media/mojo/services/default_mojo_media_client.cc View 1 2 chunks +63 lines, -43 lines 0 comments Download
M media/mojo/services/main.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M media/mojo/services/mojo_cdm_service_context.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/mojo/services/mojo_media_application.h View 1 3 chunks +1 line, -16 lines 0 comments Download
M media/mojo/services/mojo_media_application.cc View 1 2 chunks +4 lines, -30 lines 0 comments Download
M media/mojo/services/mojo_media_client.h View 1 2 chunks +3 lines, -4 lines 0 comments Download
M media/mojo/services/mojo_renderer_factory.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
hiroshige
Created Revert of Reland "media: Refactor MojoMediaClient" with fix.
4 years, 10 months ago (2016-02-15 17:15:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1702453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1702453002/1
4 years, 10 months ago (2016-02-15 17:15:20 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/146164)
4 years, 10 months ago (2016-02-15 17:21:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1702453002/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1702453002/260001
4 years, 10 months ago (2016-02-15 18:58:41 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:260001)
4 years, 10 months ago (2016-02-15 19:34:04 UTC) #9
hiroshige
A revert of this CL (patchset #2 id:260001) has been created in https://codereview.chromium.org/1697233002/ by hiroshige@chromium.org. ...
4 years, 10 months ago (2016-02-15 21:51:08 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:50:37 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/55d06b4919b3f310c48dd9520679ca9c338ffca4
Cr-Commit-Position: refs/heads/master@{#375482}

Powered by Google App Engine
This is Rietveld 408576698