Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 1702443002: [runtime] Minor tweaks to LookupIterator for performance (Closed)

Created:
4 years, 10 months ago by Toon Verwaest
Modified:
4 years, 10 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Minor tweaks to LookupIterator for performance BUG= Committed: https://crrev.com/7b59e3d7cbfe47eef4d28d41bcc2768b2b2b3678 Cr-Commit-Position: refs/heads/master@{#34024}

Patch Set 1 : rebase #

Total comments: 1

Patch Set 2 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -68 lines) Patch
M src/ic/ic.cc View 2 chunks +10 lines, -7 lines 0 comments Download
M src/lookup.h View 1 chunk +9 lines, -3 lines 0 comments Download
M src/lookup.cc View 1 3 chunks +12 lines, -18 lines 0 comments Download
M src/objects.cc View 1 5 chunks +42 lines, -40 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Toon Verwaest
ptal
4 years, 10 months ago (2016-02-15 17:07:32 UTC) #2
Camillo Bruni
lgtm with one comment https://codereview.chromium.org/1702443002/diff/40001/src/lookup.cc File src/lookup.cc (right): https://codereview.chromium.org/1702443002/diff/40001/src/lookup.cc#newcode126 src/lookup.cc:126: if (!prototype->IsNull()) return handle(JSGlobalObject::cast(prototype)); handle(JSGlobalObject::cast(prototype), ...
4 years, 10 months ago (2016-02-16 08:58:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1702443002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1702443002/60001
4 years, 10 months ago (2016-02-16 09:10:50 UTC) #8
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary files are still unsupported ...
4 years, 10 months ago (2016-02-16 09:39:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1702443002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1702443002/60001
4 years, 10 months ago (2016-02-16 09:43:00 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 10 months ago (2016-02-16 09:52:48 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 09:53:25 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7b59e3d7cbfe47eef4d28d41bcc2768b2b2b3678
Cr-Commit-Position: refs/heads/master@{#34024}

Powered by Google App Engine
This is Rietveld 408576698