Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 170243003: Makefile: don't force -Dv8_optimized_debug=0 unnecessarily (Closed)

Created:
6 years, 10 months ago by Jakob Kummerow
Modified:
6 years, 10 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Visibility:
Public.

Description

Makefile: don't force -Dv8_optimized_debug=0 unnecessarily R=machenbach@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19470

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Makefile View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
This makes it possible to manually test with -Dv8_optimized_debug=1. PTAL.
6 years, 10 months ago (2014-02-18 09:16:47 UTC) #1
Michael Achenbach
lgtm
6 years, 10 months ago (2014-02-18 11:50:54 UTC) #2
Jakob Kummerow
6 years, 10 months ago (2014-02-19 08:56:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19470 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698