Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1702393002: add last move to serialized path (Closed)

Created:
4 years, 10 months ago by caryclark
Modified:
4 years, 10 months ago
Reviewers:
reed, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

add last move to serialized path A deserialized path keeps the last move location so that a subsequent append to the path does not add an unwanted close verb. R=reed@oogle.com BUG=skia:4847 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1702393002 Committed: https://skia.googlesource.com/skia/+/6900641e02c3b6c7ee15d0aa5bd4af0d42db480f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M include/core/SkPath.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkPath.cpp View 3 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1702393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1702393002/1
4 years, 10 months ago (2016-02-17 17:09:01 UTC) #3
caryclark
PTAL
4 years, 10 months ago (2016-02-17 17:32:29 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-17 17:47:00 UTC) #6
reed1
hurray for the private version field lgtm
4 years, 10 months ago (2016-02-17 20:08:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1702393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1702393002/1
4 years, 10 months ago (2016-02-17 20:15:40 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 20:16:30 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6900641e02c3b6c7ee15d0aa5bd4af0d42db480f

Powered by Google App Engine
This is Rietveld 408576698