Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1702383005: x87: fix x87 FPU stack depth check fail issue in TurboFan's exception handler (Closed)

Created:
4 years, 10 months ago by zhengxing.li
Modified:
4 years, 10 months ago
Reviewers:
Weiliang, chunyang.dai
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

x87: fix x87 FPU stack depth check fail issue in TurboFan's exception handler Unstructured control flow caused by excpetion leads to a wrong x87 FPU stack state in TurboFan's exception handler. This patch is to reset the x87 FPU stack state when calling the TurboFan's exception handler from the CEntryStub. BUG= Committed: https://crrev.com/582ea68151b9a6bb31925f69e0bc29499044020e Cr-Commit-Position: refs/heads/master@{#34109}

Patch Set 1 #

Patch Set 2 : Revert the useless CL #33738 #

Patch Set 3 : Remove the redundant test instruction as the and instruction will set the ZF flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -27 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 1 3 chunks +14 lines, -27 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 2 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 10 months ago (2016-02-18 02:05:04 UTC) #2
Weiliang
lgtm
4 years, 10 months ago (2016-02-18 08:51:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1702383005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1702383005/40001
4 years, 10 months ago (2016-02-18 08:53:04 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-18 10:36:37 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 10:37:10 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/582ea68151b9a6bb31925f69e0bc29499044020e
Cr-Commit-Position: refs/heads/master@{#34109}

Powered by Google App Engine
This is Rietveld 408576698