Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 1702353002: Attempt to speed up v8::Object::SetPrivate (Closed)

Created:
4 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Attempt to speed up v8::Object::SetPrivate By short-cutting the DefineOwnProperty machinery similar to how ForceSet does it, we should get a few cycles out of this heavily used API. BUG=chromium:569668 R=verwaest@chromium.org LOG=n Committed: https://crrev.com/7320830db3b4a4d6c40b4f5b74478bd20d878ac8 Cr-Commit-Position: refs/heads/master@{#34102}

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -6 lines) Patch
M src/api.cc View 1 1 chunk +21 lines, -2 lines 0 comments Download
M src/objects.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jochen (gone - plz use gerrit)
4 years, 10 months ago (2016-02-17 15:09:48 UTC) #1
Toon Verwaest
https://codereview.chromium.org/1702353002/diff/1/src/api.cc File src/api.cc (right): https://codereview.chromium.org/1702353002/diff/1/src/api.cc#newcode3615 src/api.cc:3615: key_obj, &desc, i::Object::DONT_THROW); What about just calling JSProxy::AddPrivateProperty (and ...
4 years, 10 months ago (2016-02-18 08:13:51 UTC) #2
jochen (gone - plz use gerrit)
done
4 years, 10 months ago (2016-02-18 08:18:25 UTC) #3
Toon Verwaest
lgtm
4 years, 10 months ago (2016-02-18 08:19:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1702353002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1702353002/20001
4 years, 10 months ago (2016-02-18 08:20:01 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-18 08:48:39 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 08:49:22 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7320830db3b4a4d6c40b4f5b74478bd20d878ac8
Cr-Commit-Position: refs/heads/master@{#34102}

Powered by Google App Engine
This is Rietveld 408576698