Chromium Code Reviews| Index: chrome/browser/ui/passwords/manage_passwords_ui_controller.h |
| diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller.h b/chrome/browser/ui/passwords/manage_passwords_ui_controller.h |
| index 180f9d114e564b8392834ed5ce08a15e3587eeb1..fd54ac9131d8a6ef9916667c56977653036d909e 100644 |
| --- a/chrome/browser/ui/passwords/manage_passwords_ui_controller.h |
| +++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller.h |
| @@ -67,7 +67,9 @@ class ManagePasswordsUIController |
| // without user interaction. |
| virtual void UpdateIconAndBubbleState(ManagePasswordsIconView* icon); |
| - bool IsAutomaticallyOpeningBubble() const { return should_pop_up_bubble_; } |
| + bool IsAutomaticallyOpeningBubble() const { |
| + return bubble_status_ == SHOULD_POP_UP; |
| + } |
| // PasswordsModelDelegate: |
| const GURL& GetOrigin() const override; |
| @@ -132,6 +134,11 @@ class ManagePasswordsUIController |
| private: |
| friend class content::WebContentsUserData<ManagePasswordsUIController>; |
|
vabr (Chromium)
2016/02/17 14:28:42
nit: Please add a blank line after this line.
vasilii
2016/02/17 14:40:38
Done.
|
| + enum BubbleStatus { |
| + NOT_SHOWN, |
| + SHOULD_POP_UP, |
|
vabr (Chromium)
2016/02/17 14:28:42
Could you reuse the old comment from should_pop_up
vasilii
2016/02/17 14:40:38
Done.
|
| + SHOWN, |
| + }; |
| // Shows the password bubble without user interaction. |
| void ShowBubbleWithoutUserInteraction(); |
| @@ -149,9 +156,7 @@ class ManagePasswordsUIController |
| // The controller for the blocking dialogs. |
| scoped_ptr<PasswordDialogControllerImpl> dialog_controller_; |
| - // Contains true if the bubble is to be popped up in the next call to |
| - // UpdateBubbleAndIconVisibility(). |
| - bool should_pop_up_bubble_; |
| + BubbleStatus bubble_status_; |
| DISALLOW_COPY_AND_ASSIGN(ManagePasswordsUIController); |
| }; |