Don't close the password bubble on implicit navigations.

Don't close the password bubble on implicit navigations.

It's typical that some strange navigations happen in background after form submission. They shouldn't destroy the bubble.

BUG=582964, 473402, 26186
Committed: https://crrev.com/719fde6679614fd94f46a4b9630cf75611917ca5
Cr-Commit-Position: refs/heads/master@{#375889}

[vasilii, 2016-02-17 14:16:19]

Description was changed from

==========
Don't close the password bubble on implicit navigations.

BUG=582964,473402
==========

to

==========
Don't close the password bubble on implicit navigations.

It's typical that some strange navigations happen in background after form
submission. They shouldn't destroy the bubble.

BUG=582964,473402
==========

[vasilii, 2016-02-17 14:16:19]

vasilii@chromium.org changed reviewers:
+ vabr@chromium.org

[vasilii, 2016-02-17 14:16:38]

Hi Vaclav,

please review.

[vabr (Chromium), 2016-02-17 14:28:42]

Thanks, LGTM.

Will this also fix http://crbug.com/26186 (mint.com)?

Cheers,
Vaclav

https://codereview.chromium.org/1702333002/diff/1/chrome/browser/ui/passwords...
File chrome/browser/ui/passwords/manage_passwords_ui_controller.h (right):

https://codereview.chromium.org/1702333002/diff/1/chrome/browser/ui/passwords...
chrome/browser/ui/passwords/manage_passwords_ui_controller.h:136: friend class
content::WebContentsUserData<ManagePasswordsUIController>;
nit: Please add a blank line after this line.

https://codereview.chromium.org/1702333002/diff/1/chrome/browser/ui/passwords...
chrome/browser/ui/passwords/manage_passwords_ui_controller.h:139: SHOULD_POP_UP,
Could you reuse the old comment from should_pop_up_bubble_ to explain the
SHOULD_POP_UP value?

https://codereview.chromium.org/1702333002/diff/1/chrome/browser/ui/passwords...
File chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
(right):

https://codereview.chromium.org/1702333002/diff/1/chrome/browser/ui/passwords...
chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc:395: //
have been able to interact with the bubble. This happens on
nit: have -> has

[vasilii, 2016-02-17 14:36:50]

Description was changed from

==========
Don't close the password bubble on implicit navigations.

It's typical that some strange navigations happen in background after form
submission. They shouldn't destroy the bubble.

BUG=582964,473402
==========

to

==========
Don't close the password bubble on implicit navigations.

It's typical that some strange navigations happen in background after form
submission. They shouldn't destroy the bubble.

BUG=582964,473402, 26186
==========

[vasilii, 2016-02-17 14:40:38]

https://codereview.chromium.org/1702333002/diff/1/chrome/browser/ui/passwords...
File chrome/browser/ui/passwords/manage_passwords_ui_controller.h (right):

https://codereview.chromium.org/1702333002/diff/1/chrome/browser/ui/passwords...
chrome/browser/ui/passwords/manage_passwords_ui_controller.h:136: friend class
content::WebContentsUserData<ManagePasswordsUIController>;
On 2016/02/17 14:28:42, vabr (Chromium) wrote:
> nit: Please add a blank line after this line.

Done.

https://codereview.chromium.org/1702333002/diff/1/chrome/browser/ui/passwords...
chrome/browser/ui/passwords/manage_passwords_ui_controller.h:139: SHOULD_POP_UP,
On 2016/02/17 14:28:42, vabr (Chromium) wrote:
> Could you reuse the old comment from should_pop_up_bubble_ to explain the
> SHOULD_POP_UP value?

Done.

https://codereview.chromium.org/1702333002/diff/1/chrome/browser/ui/passwords...
File chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
(right):

https://codereview.chromium.org/1702333002/diff/1/chrome/browser/ui/passwords...
chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc:395: //
have been able to interact with the bubble. This happens on
On 2016/02/17 14:28:42, vabr (Chromium) wrote:
> nit: have -> has

Done.

[vasilii, 2016-02-17 14:40:49]

The CQ bit was checked by vasilii@chromium.org

[vasilii, 2016-02-17 14:40:49]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org
Link to the patchset: https://codereview.chromium.org/1702333002/#ps20001
(title: "comments")

[commit-bot: I haz the power, 2016-02-17 14:41:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1702333002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1702333002/20001

[commit-bot: I haz the power, 2016-02-17 15:31:45]

Description was changed from

==========
Don't close the password bubble on implicit navigations.

It's typical that some strange navigations happen in background after form
submission. They shouldn't destroy the bubble.

BUG=582964,473402, 26186
==========

to

==========
Don't close the password bubble on implicit navigations.

It's typical that some strange navigations happen in background after form
submission. They shouldn't destroy the bubble.

BUG=582964,473402, 26186
==========

[commit-bot: I haz the power, 2016-02-17 15:31:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-17 15:33:18]

Description was changed from

==========
Don't close the password bubble on implicit navigations.

It's typical that some strange navigations happen in background after form
submission. They shouldn't destroy the bubble.

BUG=582964,473402, 26186
==========

to

==========
Don't close the password bubble on implicit navigations.

It's typical that some strange navigations happen in background after form
submission. They shouldn't destroy the bubble.

BUG=582964,473402, 26186

Committed: https://crrev.com/719fde6679614fd94f46a4b9630cf75611917ca5
Cr-Commit-Position: refs/heads/master@{#375889}
==========

[commit-bot: I haz the power, 2016-02-17 15:33:19]

Patchset 2 (id:??) landed as
https://crrev.com/719fde6679614fd94f46a4b9630cf75611917ca5
Cr-Commit-Position: refs/heads/master@{#375889}