Source/web/WebMediaPlayerClientImpl.h - Issue 170233009: Initial implementation of AudioTrack, AudioTrackList, VideoTrack, and VideoTrackList.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebMediaPlayerClientImpl.h

Issue 170233009: Initial implementation of AudioTrack, AudioTrackList, VideoTrack, and VideoTrackList. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@blink-master

Patch Set: Rebased, reworked impl, and addressed comments. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebMediaPlayerClientImpl.h

diff --git a/Source/web/WebMediaPlayerClientImpl.h b/Source/web/WebMediaPlayerClientImpl.h

index 94501c924a9304cf6d66dfee6b73ae31efe092f5..474e9438883b5391cbc97e793a65f5bb562ae82a 100644

--- a/Source/web/WebMediaPlayerClientImpl.h

+++ b/Source/web/WebMediaPlayerClientImpl.h

@@ -87,6 +87,10 @@ public:

virtual bool needsWebLayerForVideo() const OVERRIDE;

virtual void setWebLayer(WebLayer*) OVERRIDE;

+ virtual void addVideoTrack(const WebString& id, VideoTrackKind, const WebString& label, const WebString& language, bool selected) OVERRIDE;

+ virtual void removeVideoTrack(const WebString& id) OVERRIDE;

+ virtual void addAudioTrack(const WebString& id, AudioTrackKind, const WebString& label, const WebString& language, bool enabled) OVERRIDE;

+ virtual void removeAudioTrack(const WebString& id) OVERRIDE;

virtual void addTextTrack(WebInbandTextTrack*) OVERRIDE;

virtual void removeTextTrack(WebInbandTextTrack*) OVERRIDE;

virtual void mediaSourceOpened(WebMediaSource*) OVERRIDE;

« Source/core/html/track/VideoTrackList.h ('K') | « Source/platform/graphics/media/MediaPlayer.h ('k') | Source/web/WebMediaPlayerClientImpl.cpp » ('j') | no next file with comments »