Source/core/html/track/TrackBase.cpp - Issue 170233009: Initial implementation of AudioTrack, AudioTrackList, VideoTrack, and VideoTrackList.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/track/TrackBase.cpp

Issue 170233009: Initial implementation of AudioTrack, AudioTrackList, VideoTrack, and VideoTrackList. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@blink-master

Patch Set: Rebased, reworked impl, and addressed comments. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/track/TrackBase.cpp

diff --git a/Source/core/html/track/TrackBase.cpp b/Source/core/html/track/TrackBase.cpp

index a11c065f41080f3d1d9d5b8d9e5b8b5c4a43105d..804652ee3465ce1459c8ee9faac83e12d08e3672 100644

--- a/Source/core/html/track/TrackBase.cpp

+++ b/Source/core/html/track/TrackBase.cpp

@@ -38,11 +38,13 @@ TrackBase::TrackBase(Type type, const AtomicString& label, const AtomicString& l

, m_label(label)

, m_language(language)

, m_id(id)

+ , m_mediaElement(0)

{

}

TrackBase::~TrackBase()

{

+ ASSERT(!m_mediaElement);

}

void TrackBase::setKind(const AtomicString& kind)

@@ -54,4 +56,3 @@ void TrackBase::setKind(const AtomicString& kind)

}

} // namespace WebCore

« Source/core/html/track/AudioTrackList.h ('K') | « Source/core/html/track/TrackBase.h ('k') | Source/core/html/track/TrackBaseList.h » ('j') | Source/core/html/track/TrackBaseList.h » ('J')