Source/core/html/track/AudioTrackList.idl - Issue 170233009: Initial implementation of AudioTrack, AudioTrackList, VideoTrack, and VideoTrackList.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/html/track/AudioTrackList.idl

Issue 170233009: Initial implementation of AudioTrack, AudioTrackList, VideoTrack, and VideoTrackList. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@blink-master

Patch Set: Rebase Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 [

	6 RuntimeEnabled=AudioVideoTracks

	7 ] interface AudioTrackList : EventTarget {

	8 readonly attribute unsigned long length;

	9 getter AudioTrack (unsigned long index);

	10 AudioTrack getTrackById(DOMString id);
	philipj_slow 2014/03/09 09:04:14 This is "AudioTrack?" in the spec, and that's the This is "AudioTrack?" in the spec, and that's the only difference in the IDL block. The generated IDL is identical, so I suggest the "?" here and in the other getTrackByIds. Also, trailing whitespace below. acolwell GONE FROM CHROMIUM 2014/03/18 22:02:15 Done. Show quoted text On 2014/03/09 09:04:14, philipj wrote: > This is "AudioTrack?" in the spec, and that's the only difference in the IDL > block. The generated IDL is identical, so I suggest the "?" here and in the > other getTrackByIds. Also, trailing whitespace below. Done. philipj_slow 2014/03/20 16:17:39 Thanks! The trailing whitespace is still there tho Show quoted text On 2014/03/18 22:02:15, acolwell wrote: > On 2014/03/09 09:04:14, philipj wrote: > > This is "AudioTrack?" in the spec, and that's the only difference in the IDL > > block. The generated IDL is identical, so I suggest the "?" here and in the > > other getTrackByIds. Also, trailing whitespace below. > > Done. Thanks! The trailing whitespace is still there though. (git cl apply complains about it, I don't normally look for this.) acolwell GONE FROM CHROMIUM 2014/03/28 01:32:35 Done for realz. Show quoted text On 2014/03/20 16:17:39, philipj wrote: > On 2014/03/18 22:02:15, acolwell wrote: > > On 2014/03/09 09:04:14, philipj wrote: > > > This is "AudioTrack?" in the spec, and that's the only difference in the IDL > > > block. The generated IDL is identical, so I suggest the "?" here and in the > > > other getTrackByIds. Also, trailing whitespace below. > > > > Done. > > Thanks! The trailing whitespace is still there though. (git cl apply complains > about it, I don't normally look for this.) Done for realz.
	11

	12 attribute EventHandler onchange;

	13 attribute EventHandler onaddtrack;

	14 attribute EventHandler onremovetrack;

	15 };

OLD	NEW

« Source/core/html/track/AudioTrackList.cpp ('K') | « Source/core/html/track/AudioTrackList.cpp ('k') | Source/core/html/track/TrackBase.h » ('j') | no next file with comments »