chrome/browser/extensions/PRESUBMIT_test.py - Issue 170233008: Add presubmit check and automatic update script for ExtensionPermission enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/PRESUBMIT_test.py

Issue 170233008: Add presubmit check and automatic update script for ExtensionPermission enum. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/PRESUBMIT.py ('K') | « chrome/browser/extensions/PRESUBMIT.py ('k') | extensions/common/permissions/PRESUBMIT.py » ('j') | extensions/common/permissions/PRESUBMIT.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/PRESUBMIT_test.py

diff --git a/chrome/browser/extensions/PRESUBMIT_test.py b/chrome/browser/extensions/PRESUBMIT_test.py

index ba7f9160f9c968b09c86c19ac522f06ae007e841..78b55222042cbe7d30a96e62107d5b6e6be4fbf0 100755

--- a/chrome/browser/extensions/PRESUBMIT_test.py

+++ b/chrome/browser/extensions/PRESUBMIT_test.py

@@ -144,7 +144,7 @@ class HistogramValueCheckerTest(unittest.TestCase):

else:

new_contents = self._ReadTextFileContents(new_file_path)

input_api = MockInputApi()

- mock_file = MockFile(PRESUBMIT.HistogramValueChecker.LOCAL_PATH,

+ mock_file = MockFile(PRESUBMIT.HistogramValueChecker.HIST_VALUE_LOCAL_PATH,

rpaquay 2014/02/18 21:39:26 Does this work? I am slightly confused to where HI

ahernandez 2014/02/20 17:23:42 It appears I forgot to remove this file; all of th

old_contents,

new_contents)

input_api.files.append(mock_file)