Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Side by Side Diff: extensions/common/permissions/PRESUBMIT.py

Issue 170233008: Add presubmit check and automatic update script for ExtensionPermission enum. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/browser/PRESUBMIT_test_old_file.txt ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file.
4
5 """Chromium presubmit script for src/extensions/common/permissions.
6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details on the presubmit API built into gcl.
9 """
10 import sys
11
12 def GetPreferredTrySlaves():
13 return ['linux_chromeos']
14
15 def _CreatePermissionMessageEnumChecker(input_api, output_api):
16 original_sys_path = sys.path
17
18 try:
19 sys.path.append(input_api.os_path.join(
20 input_api.PresubmitLocalPath(), '..', '..', '..', 'tools',
21 'strict_enum_value_checker'))
22 from strict_enum_value_checker import StrictEnumValueChecker
23 finally:
24 sys.path = original_sys_path
25
26 return StrictEnumValueChecker(input_api, output_api,
27 start_marker='enum ID {', end_marker=' kEnumBoundary',
28 path='extensions/common/permissions/permission_message.h')
29
30 def CheckChangeOnUpload(input_api, output_api):
31 return _CreatePermissionMessageEnumChecker(input_api, output_api).Run()
32
OLDNEW
« no previous file with comments | « extensions/browser/PRESUBMIT_test_old_file.txt ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698