extensions/browser/PRESUBMIT_test_new_file_6.txt - Issue 170233008: Add presubmit check and automatic update script for ExtensionPermission enum.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extensions/browser/PRESUBMIT_test_new_file_6.txt

Issue 170233008: Add presubmit check and automatic update script for ExtensionPermission enum. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix nits Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « extensions/browser/PRESUBMIT_test_new_file_5.txt ('k') | extensions/browser/PRESUBMIT_test_new_file_7.txt » ('j') | tools/metrics/histograms/update_histogram_enum.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 // End enum marker is before start enum marker

2

3 // Last entry: Add new entries above and ensure to update

4 // tools/metrics/histograms/histograms/histograms.xml.

5 ENUM_BOUNDARY

6 //

7 enum HistogramValue {

8 UNKNOWN = 0,

9

OLD	NEW