tools/metrics/histograms/update_extension_permission_2.py - Issue 170233008: Add presubmit check and automatic update script for ExtensionPermission enum.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/metrics/histograms/update_extension_permission_2.py

Issue 170233008: Add presubmit check and automatic update script for ExtensionPermission enum. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add new enum in histograms.xml Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« tools/metrics/histograms/histograms.xml ('K') | « tools/metrics/histograms/update_extension_functions.py ('k') | tools/metrics/histograms/update_histogram_enum.py » ('j') | tools/metrics/histograms/update_histogram_enum.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 # Copyright 2014 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.
	Ilya Sherman 2014/03/14 23:19:35 I would name this file "update_extension_permissio I would name this file "update_extension_permissions.py", i.e. replace the "_2" with an "s". The "_2" is very much an implementation detail that most people can safely ignore.
	4

	5 """Updates ExtensionPermission2 enum in histograms.xml file with values read

	6 from permission_message.h.

	7

	8 If the file was pretty-printed, the updated version is pretty-printed too.

	9 """

	10

	11 import os

	12

	13 from update_histogram_enum import UpdateHistogramEnum

	14

	15 if __name__ == '__main__':

	16 UpdateHistogramEnum(histogram_enum_name='ExtensionPermission2',

	17 source_enum_path=os.path.join('..', '..', '..',

	18 'extensions', 'common',

	19 'permissions',

	20 'permission_message.h'),

	21 start_marker='^enum ID {',

	22 end_marker='^kEnumBoundary')

OLD	NEW