Add presubmit check and automatic update script for ExtensionPermission enum.

extensions/common/permissions/PRESUBMIT.py

+# Copyright (c) 2014 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""Chromium presubmit script for src/extensions/common/permissions.
+
+See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
+for more details on the presubmit API built into gcl.
+"""
+import sys
+
+def GetPreferredTrySlaves():
+  return ['linux_chromeos']
+
+def _CheckPermissionMessageEnumValue(input_api, output_api):
+  LOCAL_PATH = "extensions/common/permissions/permission_message.h"
+  ENUM_START_MARKER = "enum ID {"
+  ENUM_END_MARKER = "  kEnumBoundary"
+  original_sys_path = sys.path
+
+  try:
+    sys.path = sys.path + [input_api.os_path.join(
+        input_api.PresubmitLocalPath(), '../../../', 'tools', 'extra_imports')]
+    from strict_enum_value_checker import StrictEnumValueChecker
+  finally:
+    sys.path = original_sys_path
+
+  return StrictEnumValueChecker(input_api, output_api, ENUM_START_MARKER,

[Jeffrey Yasskin, 2014/02/20 19:07:36]

Same comments about the function call style and 'results'.

+                                ENUM_END_MARKER, LOCAL_PATH)
+
+def CheckChangeOnUpload(input_api, output_api):
+    results = []
+    results += _CheckPermissionMessageEnumValue(input_api, output_api).Run()

[rpaquay, 2014/02/18 21:39:26]

nit: same remark as other file wrt to naming. Maybe
"_CreatePermissionMessageEnumChecker"?

+    return results
+