Add presubmit check and automatic update script for ExtensionPermission enum.

chrome/browser/extensions/PRESUBMIT_test.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import difflib
 import os
 import re
 import unittest
 
@@ skipping 126 matching lines @@
   def _ReadInputFile(self):
     return self._ReadTextFileContents("PRESUBMIT_test_old_file.txt")
 
   def _PrepareTest(self, new_file_path):
     old_contents = self._ReadInputFile()
     if not new_file_path:
       new_contents = []
     else:
       new_contents = self._ReadTextFileContents(new_file_path)
     input_api = MockInputApi()
-    mock_file = MockFile(PRESUBMIT.HistogramValueChecker.LOCAL_PATH,
+    mock_file = MockFile(PRESUBMIT.HistogramValueChecker.HIST_VALUE_LOCAL_PATH,

[rpaquay, 2014/02/18 21:39:26]

Does this work? I am slightly confused to where HIST_VALUE_LOCAL_PATH is
defined.

Also, I think we should update the tests here to test maybe a single valid and
invalid change, since most of the test cases are now covered for the factored
tools/extra_imports/strict_enum_value_checker_test.py.

[ahernandez, 2014/02/20 17:23:42]

It appears I forgot to remove this file; all of these presubmit tests are
redundant and are covered in
toos/extra_imports/strict_enum_value_checker_test.py

                          old_contents,
                          new_contents)
     input_api.files.append(mock_file)
     output_api = MockOutputApi()
     return input_api, output_api
 
   def _RunTest(self, new_file_path):
     input_api, output_api = self._PrepareTest(new_file_path)
     checker = PRESUBMIT.HistogramValueChecker(input_api, output_api)
     results = checker.Run()
@@ skipping 64 matching lines @@
   def testSingleValidDeleteOutsideOfEnum(self):
     results = self._RunTest(self.TEST_FILE_PATTERN % "10")
     # TODO(rpaquay) How to check it's the expected warning?'
     self.assertEquals(0, len(results),
                       "We should not get a warning for a deletion outside of "
                       "the enum")
 
 
 if __name__ == '__main__':
   unittest.main()