Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 170233006: fix may be used uninitialized warning on older compilers (Closed)

Created:
6 years, 10 months ago by Mostyn Bramley-Moore
Modified:
6 years, 10 months ago
Reviewers:
pdr.
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

fix may be used uninitialized warning on older compilers Some older compilers give a warning that m_block may be used uninitialized, since it's not always initialised in the LayoutScope constructor. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167358

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/core/rendering/FastTextAutosizer.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mostyn Bramley-Moore
@pdr: PTAL at this trivial patch...
6 years, 10 months ago (2014-02-18 15:09:50 UTC) #1
pdr.
On 2014/02/18 15:09:50, Mostyn Bramley-Moore wrote: > @pdr: PTAL at this trivial patch... LGTM, thanks.
6 years, 10 months ago (2014-02-18 17:50:54 UTC) #2
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 10 months ago (2014-02-18 17:50:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/170233006/1
6 years, 10 months ago (2014-02-18 17:51:06 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-18 20:29:45 UTC) #5
Message was sent while issue was closed.
Change committed as 167358

Powered by Google App Engine
This is Rietveld 408576698