Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 170233003: Make 'inputmode' attribute experimental from test. (Closed)

Created:
6 years, 10 months ago by kochi
Modified:
6 years, 10 months ago
Reviewers:
yoichio, tkent
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Visibility:
Public.

Description

Make 'inputmode' attribute experimental from test. The chromium side of the change is the only user of programmatic access to the flag, the interface (enableInputModeAttribute()) is also going to be unnecessary. This change depends on Chromium side change: https://codereview.chromium.org/170293002/ BUG=244688 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167567

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebRuntimeFeatures.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M public/web/WebRuntimeFeatures.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
yoichio
lgtm
6 years, 10 months ago (2014-02-19 01:19:46 UTC) #1
yoichio
The CQ bit was checked by yoichio@chromium.org
6 years, 10 months ago (2014-02-19 01:19:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kochi@chromium.org/170233003/1
6 years, 10 months ago (2014-02-19 01:20:04 UTC) #3
kochi
The CQ bit was unchecked by kochi@chromium.org
6 years, 10 months ago (2014-02-19 01:53:53 UTC) #4
kochi
tkent@chromium.org: Please review as OWNERS. This will be committed after https://codereview.chromium.org/170293002/.
6 years, 10 months ago (2014-02-19 02:00:09 UTC) #5
tkent
lgtm
6 years, 10 months ago (2014-02-20 03:49:45 UTC) #6
kochi
The CQ bit was checked by kochi@chromium.org
6 years, 10 months ago (2014-02-21 01:58:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kochi@chromium.org/170233003/1
6 years, 10 months ago (2014-02-21 01:59:07 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-21 04:19:38 UTC) #9
Message was sent while issue was closed.
Change committed as 167567

Powered by Google App Engine
This is Rietveld 408576698