Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: src/crankshaft/hydrogen-instructions.h

Issue 1702313002: [crankshaft] Remove the useless HAllocateBlockContext instruction. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/crankshaft/hydrogen-instructions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/crankshaft/hydrogen-instructions.h
diff --git a/src/crankshaft/hydrogen-instructions.h b/src/crankshaft/hydrogen-instructions.h
index ec281bc6dde504cd86d6bc0f7c7f7bba265e1060..22ed052ba39eccaf4500e8366d553765416b09e1 100644
--- a/src/crankshaft/hydrogen-instructions.h
+++ b/src/crankshaft/hydrogen-instructions.h
@@ -48,7 +48,6 @@ class LChunkBuilder;
V(AbnormalExit) \
V(AccessArgumentsAt) \
V(Add) \
- V(AllocateBlockContext) \
V(Allocate) \
V(ApplyArguments) \
V(ArgumentsElements) \
@@ -7668,36 +7667,6 @@ class HStoreFrameContext: public HUnaryOperation {
};
-class HAllocateBlockContext: public HTemplateInstruction<2> {
- public:
- DECLARE_INSTRUCTION_FACTORY_P3(HAllocateBlockContext, HValue*,
- HValue*, Handle<ScopeInfo>);
- HValue* context() const { return OperandAt(0); }
- HValue* function() const { return OperandAt(1); }
- Handle<ScopeInfo> scope_info() const { return scope_info_; }
-
- Representation RequiredInputRepresentation(int index) override {
- return Representation::Tagged();
- }
-
- std::ostream& PrintDataTo(std::ostream& os) const override; // NOLINT
-
- DECLARE_CONCRETE_INSTRUCTION(AllocateBlockContext)
-
- private:
- HAllocateBlockContext(HValue* context,
- HValue* function,
- Handle<ScopeInfo> scope_info)
- : scope_info_(scope_info) {
- SetOperandAt(0, context);
- SetOperandAt(1, function);
- set_representation(Representation::Tagged());
- }
-
- Handle<ScopeInfo> scope_info_;
-};
-
-
#undef DECLARE_INSTRUCTION
#undef DECLARE_CONCRETE_INSTRUCTION
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/crankshaft/hydrogen-instructions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698