Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: src/crankshaft/hydrogen-instructions.cc

Issue 1702313002: [crankshaft] Remove the useless HAllocateBlockContext instruction. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/hydrogen-instructions.h ('k') | src/crankshaft/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/hydrogen-instructions.h" 5 #include "src/crankshaft/hydrogen-instructions.h"
6 6
7 #include "src/base/bits.h" 7 #include "src/base/bits.h"
8 #include "src/base/safe_math.h" 8 #include "src/base/safe_math.h"
9 #include "src/crankshaft/hydrogen-infer-representation.h" 9 #include "src/crankshaft/hydrogen-infer-representation.h"
10 #include "src/double.h" 10 #include "src/double.h"
(...skipping 810 matching lines...) Expand 10 before | Expand all | Expand 10 after
821 case HValue::kStoreNamedGeneric: 821 case HValue::kStoreNamedGeneric:
822 case HValue::kStringCharCodeAt: 822 case HValue::kStringCharCodeAt:
823 case HValue::kStringCharFromCode: 823 case HValue::kStringCharFromCode:
824 case HValue::kThisFunction: 824 case HValue::kThisFunction:
825 case HValue::kTypeofIsAndBranch: 825 case HValue::kTypeofIsAndBranch:
826 case HValue::kUnknownOSRValue: 826 case HValue::kUnknownOSRValue:
827 case HValue::kUseConst: 827 case HValue::kUseConst:
828 return false; 828 return false;
829 829
830 case HValue::kAdd: 830 case HValue::kAdd:
831 case HValue::kAllocateBlockContext:
832 case HValue::kApplyArguments: 831 case HValue::kApplyArguments:
833 case HValue::kBitwise: 832 case HValue::kBitwise:
834 case HValue::kBoundsCheck: 833 case HValue::kBoundsCheck:
835 case HValue::kBranch: 834 case HValue::kBranch:
836 case HValue::kCallJSFunction: 835 case HValue::kCallJSFunction:
837 case HValue::kCallRuntime: 836 case HValue::kCallRuntime:
838 case HValue::kCallWithDescriptor: 837 case HValue::kCallWithDescriptor:
839 case HValue::kChange: 838 case HValue::kChange:
840 case HValue::kCheckArrayBufferNotNeutered: 839 case HValue::kCheckArrayBufferNotNeutered:
841 case HValue::kCheckHeapObject: 840 case HValue::kCheckHeapObject:
(...skipping 254 matching lines...) Expand 10 before | Expand all | Expand 10 after
1096 } 1095 }
1097 1096
1098 1097
1099 std::ostream& HAccessArgumentsAt::PrintDataTo( 1098 std::ostream& HAccessArgumentsAt::PrintDataTo(
1100 std::ostream& os) const { // NOLINT 1099 std::ostream& os) const { // NOLINT
1101 return os << NameOf(arguments()) << "[" << NameOf(index()) << "], length " 1100 return os << NameOf(arguments()) << "[" << NameOf(index()) << "], length "
1102 << NameOf(length()); 1101 << NameOf(length());
1103 } 1102 }
1104 1103
1105 1104
1106 std::ostream& HAllocateBlockContext::PrintDataTo(
1107 std::ostream& os) const { // NOLINT
1108 return os << NameOf(context()) << " " << NameOf(function());
1109 }
1110
1111
1112 std::ostream& HControlInstruction::PrintDataTo( 1105 std::ostream& HControlInstruction::PrintDataTo(
1113 std::ostream& os) const { // NOLINT 1106 std::ostream& os) const { // NOLINT
1114 os << " goto ("; 1107 os << " goto (";
1115 bool first_block = true; 1108 bool first_block = true;
1116 for (HSuccessorIterator it(this); !it.Done(); it.Advance()) { 1109 for (HSuccessorIterator it(this); !it.Done(); it.Advance()) {
1117 if (!first_block) os << ", "; 1110 if (!first_block) os << ", ";
1118 os << *it.Current(); 1111 os << *it.Current();
1119 first_block = false; 1112 first_block = false;
1120 } 1113 }
1121 return os << ")"; 1114 return os << ")";
(...skipping 3528 matching lines...) Expand 10 before | Expand all | Expand 10 after
4650 case HObjectAccess::kExternalMemory: 4643 case HObjectAccess::kExternalMemory:
4651 os << "[external-memory]"; 4644 os << "[external-memory]";
4652 break; 4645 break;
4653 } 4646 }
4654 4647
4655 return os << "@" << access.offset(); 4648 return os << "@" << access.offset();
4656 } 4649 }
4657 4650
4658 } // namespace internal 4651 } // namespace internal
4659 } // namespace v8 4652 } // namespace v8
OLDNEW
« no previous file with comments | « src/crankshaft/hydrogen-instructions.h ('k') | src/crankshaft/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698