Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1479)

Issue 1702283002: Changes to quick_launch and font_services (Closed)

Created:
4 years, 10 months ago by sky
Modified:
4 years, 10 months ago
CC:
chromium-reviews, kalyank, sadrul, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changes to quick_launch and font_services Separates out a lib for quick_launch and overrides AcceptConnection to return true so that we don't continually try to restart it. Adds a manifest for font_services. And makes AuraInit CHECK if it can't find resources. BUG=581539 TEST=none R=ben@chromium.org Committed: https://crrev.com/1d312b1267c3475487391530309d8d9149c8d237 Cr-Commit-Position: refs/heads/master@{#375904}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -155 lines) Patch
M components/font_service/BUILD.gn View 3 chunks +7 lines, -0 lines 0 comments Download
A components/font_service/manifest.json View 1 chunk +5 lines, -0 lines 0 comments Download
M mash/quick_launch/BUILD.gn View 1 chunk +16 lines, -4 lines 0 comments Download
A + mash/quick_launch/main.cc View 1 chunk +3 lines, -2 lines 0 comments Download
D mash/quick_launch/quick_launch.cc View 1 chunk +0 lines, -119 lines 0 comments Download
A mash/quick_launch/quick_launch_application.h View 1 chunk +41 lines, -0 lines 0 comments Download
A + mash/quick_launch/quick_launch_application.cc View 3 chunks +18 lines, -28 lines 0 comments Download
M ui/views/mus/aura_init.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
sky
4 years, 10 months ago (2016-02-17 04:33:58 UTC) #2
Ben Goodger (Google)
lgtm
4 years, 10 months ago (2016-02-17 05:06:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1702283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1702283002/1
4 years, 10 months ago (2016-02-17 16:43:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-17 16:50:02 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 16:51:23 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1d312b1267c3475487391530309d8d9149c8d237
Cr-Commit-Position: refs/heads/master@{#375904}

Powered by Google App Engine
This is Rietveld 408576698