Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1702273002: Move use_suid_sandbox_for_adj_oom_score_ logic to zygote_host_impl_linux.cc. (Closed)

Created:
4 years, 10 months ago by rickyz (no longer on Chrome)
Modified:
4 years, 10 months ago
Reviewers:
Greg K, mdempsky
CC:
chromium-reviews, darin-cc_chromium.org, jam, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move use_suid_sandbox_for_adj_oom_score_ logic to zygote_host_impl_linux.cc. Previous refactoring had split the definition and use of this variable into two different classes, resulting in use_suid_sandbox_for_adj_oom_score_ effectively always being false. TBR=mdempsky@chromium.org,kerrnel@chromium.org BUG=576409 Committed: https://crrev.com/7a5332d762625352a252355a3d7735dd2de4fbea Cr-Commit-Position: refs/heads/master@{#375781}

Patch Set 1 #

Patch Set 2 : Set should_use_namespace_sandbox_ in Init. #

Patch Set 3 : Fix comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -35 lines) Patch
M content/browser/zygote_host/zygote_communication_linux.cc View 1 5 chunks +3 lines, -34 lines 0 comments Download
M content/browser/zygote_host/zygote_host_impl_linux.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/zygote_host/zygote_host_impl_linux.cc View 1 2 4 chunks +35 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1702273002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1702273002/20001
4 years, 10 months ago (2016-02-17 02:07:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1702273002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1702273002/40001
4 years, 10 months ago (2016-02-17 02:11:12 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-17 04:12:52 UTC) #8
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/7a5332d762625352a252355a3d7735dd2de4fbea Cr-Commit-Position: refs/heads/master@{#375781}
4 years, 10 months ago (2016-02-17 04:13:58 UTC) #10
mdempsky
4 years, 10 months ago (2016-02-17 06:55:12 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698