components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc - Issue 1702253002: Log more data reduction proxy config service UMA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc

Issue 1702253002: Log more data reduction proxy config service UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased, use boolean histogram Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc

index 4661367b041e1caa3b7075815377f12e2fb77511..d0f1dbc69c33419c8ca3bc72e24024ca5802b4a0 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc

@@ -835,6 +835,11 @@ bool DataReductionProxyConfig::ShouldEnableLoFiMode(

return enable_lofi;

}

+bool DataReductionProxyConfig::enabled_by_user_and_reachable() const {

+ DCHECK(thread_checker_.CalledOnValidThread());

+ return enabled_by_user_ && !unreachable_;

bool DataReductionProxyConfig::ShouldEnableLoFiModeInternal(

const net::NetworkQualityEstimator* network_quality_estimator) {

DCHECK(thread_checker_.CalledOnValidThread());