third_party/WebKit/Source/modules/payments/PaymentResponse.cpp - Issue 1702223002: PaymentRequest API.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/payments/PaymentResponse.cpp

Issue 1702223002: PaymentRequest API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "modules/payments/PaymentResponse.h"

	6

	7 #include "bindings/core/v8/ScriptPromiseResolver.h"

	8

	9 namespace blink {

	10

	11 PaymentResponse::PaymentResponse()

	12 {

	13 }

	14

	15 PaymentResponse::~PaymentResponse()

	16 {

	17 }

	18

	19 ScriptPromise PaymentResponse::complete(ScriptState* scriptState, bool success)

	20 {

	21 return ScriptPromiseResolver::create(scriptState)->promise();
	Marijn Kruisselbrink 2016/02/18 21:59:18 Don't create and not resolve a ScriptPromiseResolv Don't create and not resolve a ScriptPromiseResolver, just return a rejected promise (see my previous comment). please use gerrit instead 2016/02/18 22:41:33 Done. Show quoted text On 2016/02/18 21:59:18, Marijn Kruisselbrink wrote: > Don't create and not resolve a ScriptPromiseResolver, just return a rejected > promise (see my previous comment). Done.
	22 }

	23

	24 } // namespace blink

OLD	NEW