Issue 17022009: Force set the new tab title in instant extended.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17022009: Force set the new tab title in instant extended. (Closed)

Created:
7 years, 6 months ago by brettw

Modified:
7 years, 6 months ago

Reviewers:
samarth

CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, mad+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Force set the new tab title in instant extended. This eliminates the chance of getting a flash of the URL in the new tab title before the page has loaded. BUG=196422 R=samarth@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207918

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : #

Patch Set 4 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -2 lines)			Patch
M	chrome/browser/resources/local_ntp/local_ntp.js	View	1 2 3	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/search/instant_loader.cc	View	1 2	2 chunks	+13 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/search/search_tab_helper.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/search/search_tab_helper.cc	View	1 2	2 chunks	+24 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

samarth

lgtm Huh, just tried session restore and that seemed to work as expected. This is ...

7 years, 6 months ago (2013-06-20 20:41:16 UTC) #2

brettw

PTAL, I added some new code to handle the edge cases of reload (and probably ...

7 years, 6 months ago (2013-06-20 23:21:52 UTC) #3

brettw

7 years, 6 months ago (2013-06-21 21:03:17 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r207918 (presubmit successful).

Expand Messages | Collapse Messages