Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: chrome/browser/autocomplete/search_provider.h

Issue 17022004: Replace --google-base-suggest-url and --instant-url with --google-base-url. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/search_provider.h
===================================================================
--- chrome/browser/autocomplete/search_provider.h (revision 208572)
+++ chrome/browser/autocomplete/search_provider.h (working copy)
@@ -61,24 +61,35 @@
SearchProvider(AutocompleteProviderListener* listener, Profile* profile);
- // Returns an AutocompleteMatch representing a search for |query_string|
- // using the provider identified by |keyword|. |is_keyword| should be true if
- // |input| represents a keyword search (even if it's for the default search
- // provider). |input_text| (the original input text) and |accepted_suggestion|
- // are used to generate Assisted Query Stats.
- // Returns a match with an invalid destination_url in case of any errors.
+ // Returns an AutocompleteMatch with the given |autocomplete_provider|,
+ // |relevance|, and |type|, which represents a search via |template_url| for
+ // |query_string|. If |template_url| is NULL, returns a match with an invalid
+ // destination URL.
+ //
+ // |input_text| is the original user input, which may differ from
+ // |query_string|; e.g. the user typed "foo" and got a search suggestion of
+ // "food", which we're now marking up. This is used to highlight portions of
+ // the match contents to distinguish locally-typed text from suggested text.
+ //
+ // |input| and |is_keyword| are necessary for various other details, like
+ // whether we should allow inline autocompletion and what the transition type
+ // should be. |accepted_suggestion| and |omnibox_start_margin| are used along
+ // with |input_text| to generate Assisted Query Stats.
+ // |append_extra_query_params| should be set if |template_url| is the default
+ // search engine, so the destination URL will contain any
+ // command-line-specified query params.
static AutocompleteMatch CreateSearchSuggestion(
- Profile* profile,
AutocompleteProvider* autocomplete_provider,
- const AutocompleteInput& input,
+ int relevance,
+ AutocompleteMatch::Type type,
+ const TemplateURL* template_url,
const string16& query_string,
const string16& input_text,
- int relevance,
- AutocompleteMatch::Type type,
+ const AutocompleteInput& input,
+ bool is_keyword,
int accepted_suggestion,
- bool is_keyword,
- const string16& keyword,
- int omnibox_start_margin);
+ int omnibox_start_margin,
+ bool append_extra_query_params);
// AutocompleteProvider:
virtual void AddProviderInfo(ProvidersInfo* provider_info) const OVERRIDE;
« no previous file with comments | « chrome/browser/autocomplete/keyword_provider_unittest.cc ('k') | chrome/browser/autocomplete/search_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698