Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1702103002: Add an even simpler standalone example. (Closed)

Created:
4 years, 10 months ago by viettrungluu
Modified:
4 years, 10 months ago
Reviewers:
vardhan, kulakowski
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add an even simpler standalone example. This example is like the echo examples, but has no dependencies outside of //mojo/public (in particular, no //base dependency). R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/d1f4c06265d3fdf9b923862cb7932264a9dd4ee5

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -23 lines) Patch
M examples/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + examples/hello_mojo/BUILD.gn View 1 chunk +16 lines, -19 lines 0 comments Download
A examples/hello_mojo/README.md View 1 chunk +17 lines, -0 lines 0 comments Download
A + examples/hello_mojo/hello_mojo.mojom View 1 chunk +5 lines, -4 lines 0 comments Download
A examples/hello_mojo/hello_mojo_client.cc View 1 chunk +52 lines, -0 lines 1 comment Download
A examples/hello_mojo/hello_mojo_server.cc View 1 chunk +70 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
viettrungluu
4 years, 10 months ago (2016-02-16 18:29:32 UTC) #1
viettrungluu
I should add that the main point of this is to give me something to ...
4 years, 10 months ago (2016-02-16 18:30:31 UTC) #2
kulakowski
https://codereview.chromium.org/1702103002/diff/1/examples/hello_mojo/hello_mojo_client.cc File examples/hello_mojo/hello_mojo_client.cc (right): https://codereview.chromium.org/1702103002/diff/1/examples/hello_mojo/hello_mojo_client.cc#newcode50 examples/hello_mojo/hello_mojo_client.cc:50: new HelloMojoClientApp())) clang format makes me happy sometimes
4 years, 10 months ago (2016-02-16 18:35:54 UTC) #4
vardhan
lgtm
4 years, 10 months ago (2016-02-16 19:03:57 UTC) #5
viettrungluu
4 years, 10 months ago (2016-02-16 20:22:09 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d1f4c06265d3fdf9b923862cb7932264a9dd4ee5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698