Move SkTArray to include/private.

Move SkTArray to include/private.

TBR=reed
Agreed moving to private is good.

Committed: https://skia.googlesource.com/skia/+/bf521ff9415b3bdb1acde7b8d18139df176236e5

[bungeman-skia, 2016-02-16 17:48:31]

Description was changed from

==========
Move SkTArray to include/private.
==========

to

==========
Move SkTArray to include/private.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bungeman-skia, 2016-02-16 17:48:57]

Description was changed from

==========
Move SkTArray to include/private.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Move SkTArray to include/private.
==========

[bungeman-skia, 2016-02-16 17:49:03]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-16 17:49:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1702073002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1702073002/1

[bungeman-skia, 2016-02-16 17:54:58]

bungeman@google.com changed reviewers:
+ mtklein@google.com, reed@google.com

[bungeman-skia, 2016-02-16 17:54:59]

https://codereview.chromium.org/1702073002/diff/1/bench/ResultsWriter.h
File bench/ResultsWriter.h (left):

https://codereview.chromium.org/1702073002/diff/1/bench/ResultsWriter.h#oldco...
bench/ResultsWriter.h:18: #include "SkTArray.h"
Never used.

https://codereview.chromium.org/1702073002/diff/1/include/core/SkTextBlob.h
File include/core/SkTextBlob.h (left):

https://codereview.chromium.org/1702073002/diff/1/include/core/SkTextBlob.h#o...
include/core/SkTextBlob.h:14: #include "SkTDArray.h"
Turns out SkAutoTMalloc ended up being used, but neither of these.

https://codereview.chromium.org/1702073002/diff/1/include/gpu/GrTypesPriv.h
File include/gpu/GrTypesPriv.h (left):

https://codereview.chromium.org/1702073002/diff/1/include/gpu/GrTypesPriv.h#o...
include/gpu/GrTypesPriv.h:12: #include "SkTArray.h"
Wasn't used.

https://codereview.chromium.org/1702073002/diff/1/include/ports/SkFontConfigI...
File include/ports/SkFontConfigInterface.h (left):

https://codereview.chromium.org/1702073002/diff/1/include/ports/SkFontConfigI...
include/ports/SkFontConfigInterface.h:14: #include "SkTArray.h"
Used in a public interface which was introduced at some point, but apparently
never used. Instead of updating the interface, just remove this method, which
never had a working implementation.

https://codereview.chromium.org/1702073002/diff/1/include/utils/SkRTConf.h
File include/utils/SkRTConf.h (left):

https://codereview.chromium.org/1702073002/diff/1/include/utils/SkRTConf.h#ol...
include/utils/SkRTConf.h:12: #include "SkTArray.h"
This one used SkTDArray, but not SkTArray. SkTDArray may be moved in a separate
CL.

[commit-bot: I haz the power, 2016-02-16 18:31:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-16 18:31:38]

Dry run: This issue passed the CQ dry run.

[bungeman-skia, 2016-02-16 19:08:43]

https://codereview.chromium.org/1702073002/diff/1/src/gpu/GrContextFactory.h
File src/gpu/GrContextFactory.h (right):

https://codereview.chromium.org/1702073002/diff/1/src/gpu/GrContextFactory.h#...
src/gpu/GrContextFactory.h:15: #include "../private/SkTArray.h"
This one is probably the most iffy. This shouldn't be necessary (since this is
in 'src'), but this header is included by 'tools/flags/SkCommonFlagsConfig.h'
included by SkCommonFlagsConfig.cpp. Perhaps it would be better to just have the
flags target include private (it already apparently includes 'src', which is
much stronger).

[mtklein, 2016-02-16 19:16:14]

https://codereview.chromium.org/1702073002/diff/1/src/gpu/GrContextFactory.h
File src/gpu/GrContextFactory.h (right):

https://codereview.chromium.org/1702073002/diff/1/src/gpu/GrContextFactory.h#...
src/gpu/GrContextFactory.h:15: #include "../private/SkTArray.h"
On 2016/02/16 19:08:43, bungeman1 wrote:
> This one is probably the most iffy. This shouldn't be necessary (since this is
> in 'src'), but this header is included by 'tools/flags/SkCommonFlagsConfig.h'
> included by SkCommonFlagsConfig.cpp. Perhaps it would be better to just have
the
> flags target include private (it already apparently includes 'src', which is
> much stronger).

Sounds right to me.

[bungeman-skia, 2016-02-16 19:18:16]

Description was changed from

==========
Move SkTArray to include/private.
==========

to

==========
Move SkTArray to include/private.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bungeman-skia, 2016-02-16 19:18:29]

Description was changed from

==========
Move SkTArray to include/private.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Move SkTArray to include/private.
==========

[bungeman-skia, 2016-02-16 19:19:01]

https://codereview.chromium.org/1702073002/diff/1/src/gpu/GrContextFactory.h
File src/gpu/GrContextFactory.h (right):

https://codereview.chromium.org/1702073002/diff/1/src/gpu/GrContextFactory.h#...
src/gpu/GrContextFactory.h:15: #include "../private/SkTArray.h"
On 2016/02/16 19:16:14, mtklein wrote:
> On 2016/02/16 19:08:43, bungeman1 wrote:
> > This one is probably the most iffy. This shouldn't be necessary (since this
is
> > in 'src'), but this header is included by
'tools/flags/SkCommonFlagsConfig.h'
> > included by SkCommonFlagsConfig.cpp. Perhaps it would be better to just have
> the
> > flags target include private (it already apparently includes 'src', which is
> > much stronger).
> 
> Sounds right to me.

Done.

[bungeman-skia, 2016-02-16 19:19:08]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-16 19:19:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1702073002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1702073002/20001

[commit-bot: I haz the power, 2016-02-16 19:21:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-16 19:21:31]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)

[mtklein, 2016-02-16 19:23:13]

lgtm

might want to spin off that delete-font-API stuff from the rest?

[bungeman-skia, 2016-02-16 20:03:27]

Description was changed from

==========
Move SkTArray to include/private.
==========

to

==========
Move SkTArray to include/private.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bungeman-skia, 2016-02-16 20:03:38]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-16 20:03:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1702073002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1702073002/40001

[bungeman-skia, 2016-02-16 20:03:58]

Description was changed from

==========
Move SkTArray to include/private.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Move SkTArray to include/private.
==========

[commit-bot: I haz the power, 2016-02-16 20:28:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-16 20:28:24]

Dry run: This issue passed the CQ dry run.

[bungeman-skia, 2016-02-17 20:43:51]

On 2016/02/16 20:28:24, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

I've now also locally built this with Chromium Linux and Android.

[bungeman-skia, 2016-02-17 20:47:07]

Description was changed from

==========
Move SkTArray to include/private.
==========

to

==========
Move SkTArray to include/private.

TBR=reed
Agreed moving to private is good.
==========

[bungeman-skia, 2016-02-17 20:47:59]

The CQ bit was checked by bungeman@google.com

[bungeman-skia, 2016-02-17 20:47:59]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/1702073002/#ps40001
(title: "Fix kilobench.")

[commit-bot: I haz the power, 2016-02-17 20:48:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1702073002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1702073002/40001

[commit-bot: I haz the power, 2016-02-17 21:13:46]

Description was changed from

==========
Move SkTArray to include/private.

TBR=reed
Agreed moving to private is good.
==========

to

==========
Move SkTArray to include/private.

TBR=reed
Agreed moving to private is good.

Committed:
https://skia.googlesource.com/skia/+/bf521ff9415b3bdb1acde7b8d18139df176236e5
==========

[commit-bot: I haz the power, 2016-02-17 21:13:47]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/bf521ff9415b3bdb1acde7b8d18139df176236e5