Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2504)

Unified Diff: chrome/browser/resources/settings/search_engines_page/search_engines_page.js

Issue 1702063003: MD Settings: Creating WebUIListenerBehavior helper. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@manage_search_engines_ui1
Patch Set: Resolve conflicts with ToT Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/search_engines_page/search_engines_page.js
diff --git a/chrome/browser/resources/settings/search_engines_page/search_engines_page.js b/chrome/browser/resources/settings/search_engines_page/search_engines_page.js
index 2f58998237c4c9d80fbf9d4602d934dd577f5f97..56fd8411c2d8ab62ce6b8fe62934139d1bee2b8f 100644
--- a/chrome/browser/resources/settings/search_engines_page/search_engines_page.js
+++ b/chrome/browser/resources/settings/search_engines_page/search_engines_page.js
@@ -12,6 +12,8 @@
Polymer({
is: 'settings-search-engines-page',
+ behaviors: [settings.WebUIListenerBehavior],
+
properties: {
/** @type {!Array<!SearchEngine>} */
defaultEngines: {
@@ -35,28 +37,12 @@ Polymer({
},
},
- /**
- * Holds WebUI listeners that need to be removed when this element is
- * destroyed.
- * TODO(dpapad): Move listener tracking logic to a Polymer behavior class,
- * such that it can be re-used.
- * @private {!Array<!WebUIListener>}
- */
- webUIListeners_: [],
-
/** @override */
ready: function() {
settings.SearchEnginesBrowserProxyImpl.getInstance().
getSearchEnginesList().then(this.enginesChanged_.bind(this));
- this.webUIListeners_.push(cr.addWebUIListener(
- 'search-engines-changed', this.enginesChanged_.bind(this)));
- },
-
- /** @override */
- detached: function() {
- this.webUIListeners_.forEach(function(listener) {
- cr.removeWebUIListener(listener);
- });
+ this.addWebUIListener(
+ 'search-engines-changed', this.enginesChanged_.bind(this));
},
/**

Powered by Google App Engine
This is Rietveld 408576698