src/wasm/asm-wasm-builder.cc - Issue 1702063002: Non-pattern rewriting revisited

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/wasm/asm-wasm-builder.cc

Issue 1702063002: Non-pattern rewriting revisited (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/wasm/asm-wasm-builder.cc

diff --git a/src/wasm/asm-wasm-builder.cc b/src/wasm/asm-wasm-builder.cc

index ca31c977f9852e538dfc3a171c23e9b1e4bbc424..690d53c11317a55a2e263053e038303094d60faa 100644

--- a/src/wasm/asm-wasm-builder.cc

+++ b/src/wasm/asm-wasm-builder.cc

@@ -1169,10 +1169,7 @@ class AsmWasmBuilderImpl : public AstVisitor {

void VisitDoExpression(DoExpression* expr) { UNREACHABLE(); }

- void VisitRewritableAssignmentExpression(

- RewritableAssignmentExpression* expr) {

- UNREACHABLE();

- }

+ void VisitRewritableExpression(RewritableExpression* expr) { UNREACHABLE(); }

struct IndexContainer : public ZoneObject {

uint16_t index;

« src/parsing/pattern-rewriter.cc ('K') | « src/typing-asm.cc ('k') | no next file » | no next file with comments »