Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 170203003: Use ComputeHandlerFlags to find handlers, rather than manually encoding. (Closed)

Created:
6 years, 10 months ago by Toon Verwaest
Modified:
6 years, 10 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Visibility:
Public.

Description

Use ComputeHandlerFlags to find handlers, rather than manually encoding. BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19510

Patch Set 1 #

Patch Set 2 : Remove debug code again #

Patch Set 3 : Reenable ASSERT and check type after cache hit. #

Patch Set 4 : Move type handling into lookup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -11 lines) Patch
M src/ic.cc View 1 2 3 1 chunk +11 lines, -2 lines 0 comments Download
M src/objects.cc View 1 2 3 1 chunk +5 lines, -3 lines 0 comments Download
M src/stub-cache.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M src/stub-cache.cc View 1 2 3 2 chunks +14 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 10 months ago (2014-02-20 11:30:34 UTC) #1
Igor Sheludko
lgtm
6 years, 10 months ago (2014-02-20 12:37:06 UTC) #2
Toon Verwaest
6 years, 10 months ago (2014-02-20 12:40:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r19510 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698