[wasm] Replace the BufferedRawMachineAssemblerTester in the WasmRunner.

[wasm] Replace the BufferedRawMachineAssemblerTester in the WasmRunner.

The BufferedRawMachineAssemblerTester caused problems for the
Int64Lowering. Instead we construct a TF graph now which is compiled by
Pipeline::GenerateCodeForTesting.

R=titzer@chromium.org

Committed: https://crrev.com/f8e068e926fb06bead28bdfbdab7a1cf1afe27df
Cr-Commit-Position: refs/heads/master@{#34107}

[ahaas, 2016-02-17 08:49:47]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-17 08:50:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1702023002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1702023002/1

[commit-bot: I haz the power, 2016-02-17 09:24:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-17 09:24:56]

Dry run: Try jobs failed on following builders:
  v8_win_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/2908)
  v8_win_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng_triggered/bui...)

[ahaas, 2016-02-17 18:28:48]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-17 18:28:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1702023002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1702023002/80001

[commit-bot: I haz the power, 2016-02-17 18:47:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-17 18:47:03]

Dry run: This issue passed the CQ dry run.

[titzer, 2016-02-18 08:18:49]

lgtm with comments below

https://codereview.chromium.org/1702023002/diff/80001/test/cctest/wasm/test-r...
File test/cctest/wasm/test-run-wasm-js.cc (right):

https://codereview.chromium.org/1702023002/diff/80001/test/cctest/wasm/test-r...
test/cctest/wasm/test-run-wasm-js.cc:13: #include
"test/cctest/compiler/value-helper.h"
Superfluous include?

https://codereview.chromium.org/1702023002/diff/80001/test/cctest/wasm/wasm-r...
File test/cctest/wasm/wasm-run-utils.h (right):

https://codereview.chromium.org/1702023002/diff/80001/test/cctest/wasm/wasm-r...
test/cctest/wasm/wasm-run-utils.h:516: CHECK_EQ(7654, result);
Pull this constant out somewhere.

[ahaas, 2016-02-18 09:10:57]

https://codereview.chromium.org/1702023002/diff/80001/test/cctest/wasm/test-r...
File test/cctest/wasm/test-run-wasm-js.cc (right):

https://codereview.chromium.org/1702023002/diff/80001/test/cctest/wasm/test-r...
test/cctest/wasm/test-run-wasm-js.cc:13: #include
"test/cctest/compiler/value-helper.h"
On 2016/02/18 at 08:18:49, titzer wrote:
> Superfluous include?

The reason for this include is the use of CheckFloatEq and CheckDoubleEq. These
were originally included through wasm-run-utils.h but now have to be included
explicitly.

https://codereview.chromium.org/1702023002/diff/80001/test/cctest/wasm/wasm-r...
File test/cctest/wasm/wasm-run-utils.h (right):

https://codereview.chromium.org/1702023002/diff/80001/test/cctest/wasm/wasm-r...
test/cctest/wasm/wasm-run-utils.h:516: CHECK_EQ(7654, result);
On 2016/02/18 at 08:18:49, titzer wrote:
> Pull this constant out somewhere.

Done.

[titzer, 2016-02-18 09:13:18]

On 2016/02/18 09:10:57, ahaas wrote:
>
https://codereview.chromium.org/1702023002/diff/80001/test/cctest/wasm/test-r...
> File test/cctest/wasm/test-run-wasm-js.cc (right):
> 
>
https://codereview.chromium.org/1702023002/diff/80001/test/cctest/wasm/test-r...
> test/cctest/wasm/test-run-wasm-js.cc:13: #include
> "test/cctest/compiler/value-helper.h"
> On 2016/02/18 at 08:18:49, titzer wrote:
> > Superfluous include?
> 
> The reason for this include is the use of CheckFloatEq and CheckDoubleEq.
These
> were originally included through wasm-run-utils.h but now have to be included
> explicitly.
> 
>
https://codereview.chromium.org/1702023002/diff/80001/test/cctest/wasm/wasm-r...
> File test/cctest/wasm/wasm-run-utils.h (right):
> 
>
https://codereview.chromium.org/1702023002/diff/80001/test/cctest/wasm/wasm-r...
> test/cctest/wasm/wasm-run-utils.h:516: CHECK_EQ(7654, result);
> On 2016/02/18 at 08:18:49, titzer wrote:
> > Pull this constant out somewhere.
> 
> Done.

lgtm

[ahaas, 2016-02-18 09:39:52]

The CQ bit was checked by ahaas@chromium.org

[commit-bot: I haz the power, 2016-02-18 09:39:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1702023002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1702023002/100001

[commit-bot: I haz the power, 2016-02-18 09:55:29]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-02-18 09:55:56]

Description was changed from

==========
[wasm] Replace the BufferedRawMachineAssemblerTester in the WasmRunner.

The BufferedRawMachineAssemblerTester caused problems for the
Int64Lowering. Instead we construct a TF graph now which is compiled by
Pipeline::GenerateCodeForTesting.

R=titzer@chromium.org
==========

to

==========
[wasm] Replace the BufferedRawMachineAssemblerTester in the WasmRunner.

The BufferedRawMachineAssemblerTester caused problems for the
Int64Lowering. Instead we construct a TF graph now which is compiled by
Pipeline::GenerateCodeForTesting.

R=titzer@chromium.org

Committed: https://crrev.com/f8e068e926fb06bead28bdfbdab7a1cf1afe27df
Cr-Commit-Position: refs/heads/master@{#34107}
==========

[commit-bot: I haz the power, 2016-02-18 09:55:57]

Patchset 6 (id:??) landed as
https://crrev.com/f8e068e926fb06bead28bdfbdab7a1cf1afe27df
Cr-Commit-Position: refs/heads/master@{#34107}