Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 1702013004: Revert of Iteratively increase sample size for good/bad classification. (Closed)

Created:
4 years, 10 months ago by RobertoCN
Modified:
4 years, 10 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Iteratively increase sample size for good/bad classification. (patchset #12 id:220001 of https://codereview.chromium.org/1610203003/ ) Reason for revert: return_code bisects fail with this approach Original issue's description: > Iteratively increase sample size for good/bad classification. > > This change makes the bisect recipe use scipy's implementation of > Mann-Whitney's U test to determine if a significant different exists > between two given revisions. > > It also changes the bisection step by requiring more tests to be run > when the sample is insufficient to establish a difference between the > revision being evaluated and either of the FKBR/LKGR. > > R=dtu,qyearsley,prasadv > BUG=565606 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298810 TBR=dtu@chromium.org,prasadv@chromium.org,qyearsley@chromium.org,vadimsh@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=565606 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298811

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -827 lines) Patch
M scripts/slave/recipe_modules/auto_bisect/api.py View 2 chunks +46 lines, -54 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/bisector.py View 6 chunks +22 lines, -79 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/bisector_test.py View 2 chunks +14 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.py View 7 chunks +8 lines, -8 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/android_arm64_bisector.json View 4 chunks +6 lines, -37 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/android_bisector.json View 4 chunks +6 lines, -37 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/basic.json View 4 chunks +6 lines, -37 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/basic_bisect_script.json View 4 chunks +6 lines, -37 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/failed_build_test.json View 2 chunks +4 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/failed_test.json View 3 chunks +6 lines, -3 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/mac_bisector.json View 4 chunks +6 lines, -37 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/missing_metric_test.json View 2 chunks +4 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/reversed_basic.json View 4 chunks +6 lines, -37 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/windows_bisector.json View 4 chunks +6 lines, -37 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/windows_x64_bisector.json View 4 chunks +6 lines, -37 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/perf_revision_state.py View 9 chunks +17 lines, -79 lines 0 comments Download
D scripts/slave/recipe_modules/auto_bisect/resources/significantly_different.py View 1 chunk +0 lines, -37 lines 0 comments Download
D scripts/slave/recipe_modules/auto_bisect/resources/significantly_different_inner.py View 1 chunk +0 lines, -49 lines 0 comments Download
D scripts/slave/recipe_modules/auto_bisect/resources/significantly_different_test.py View 1 chunk +0 lines, -38 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/revision_state.py View 4 chunks +8 lines, -18 lines 0 comments Download
M scripts/slave/recipe_modules/bisect_tester/api.py View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipe_modules/bisect_tester/perf_test.py View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/bisect.expected/basic.json View 6 chunks +8 lines, -76 lines 0 comments Download
M scripts/slave/recipes/bisect.expected/basic_return_code_test.json View 6 chunks +8 lines, -76 lines 0 comments Download
M scripts/slave/recipes/bisect.expected/broken_bad_revision_test.json View 2 chunks +4 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisect.expected/broken_good_revision_test.json View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
RobertoCN
Created Revert of Iteratively increase sample size for good/bad classification.
4 years, 10 months ago (2016-02-16 19:48:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1702013004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1702013004/1
4 years, 10 months ago (2016-02-16 19:48:23 UTC) #2
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 19:48:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298811

Powered by Google App Engine
This is Rietveld 408576698