Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1702013002: Reland of Have gn gen assert that the output directory does not have GYP artifacts (Closed)

Created:
4 years, 10 months ago by agrieve
Modified:
4 years, 10 months ago
Reviewers:
mdjones, brettw, jbudorick, dgn
CC:
chromium-reviews, Primiano Tucci (use gerrit), Yaron, mlamouri (slow - plz ping)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Have gn gen assert that the output directory does not have GYP artifacts (patchset #1 id:1 of https://codereview.chromium.org/1602393002/ ) Reason for revert: Verified manually (via ssh) that patch works fine on a trybot that broke last time. Perhaps more time just needed to pass? Original issue's description: > Revert of Have gn gen assert that the output directory does not have GYP artifacts (patchset #2 id:20001 of https://codereview.chromium.org/1601893002/ ) > > Reason for revert: > arm-builder-rel, arm64-builder-rel, gn-release-builder-l consistently fail the assertion added in this change. > > Original issue's description: > > Have gn gen assert that the output directory does not have GYP artifacts > > > > This can often lead to compile errors. > > > > BUG=578862 > > > > Committed: https://crrev.com/5915049689627393a3eb8f531f3a361eedcfbce0 > > Cr-Commit-Position: refs/heads/master@{#370210} > > TBR=brettw@chromium.org,agrieve@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=578862 > > Committed: https://crrev.com/caf664a996be25ec5f567f183dd897de4abff952 > Cr-Commit-Position: refs/heads/master@{#370288} TBR=brettw@chromium.org,jbudorick@chromium.org,mdjones@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=578862 Committed: https://crrev.com/92a9e0684f6a76060f59a9c8caab0420bc36ec06 Cr-Commit-Position: refs/heads/master@{#375598}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M .gn View 1 chunk +1 line, -0 lines 0 comments Download
M build/config/BUILD.gn View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
agrieve
Created Reland of Have gn gen assert that the output directory does not have GYP ...
4 years, 10 months ago (2016-02-16 15:37:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1702013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1702013002/1
4 years, 10 months ago (2016-02-16 15:42:24 UTC) #5
jbudorick
lgtm
4 years, 10 months ago (2016-02-16 15:44:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-16 16:54:48 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:53:19 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/92a9e0684f6a76060f59a9c8caab0420bc36ec06
Cr-Commit-Position: refs/heads/master@{#375598}

Powered by Google App Engine
This is Rietveld 408576698