Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 1701983004: X87: [runtime] Turn ArgumentAccessStub into FastNewSloppyArgumentsStub. (Closed)

Created:
4 years, 10 months ago by zhengxing.li
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [runtime] Turn ArgumentAccessStub into FastNewSloppyArgumentsStub. port e0129d0f87677722a2cef055e372ab1e805cacf1 (r33986) original commit message: Turn the fast case of ArgumentsAccessStub into a new stub FastNewSloppyArgumentsStub, which is similar to the existing FastNewStrictArgumentsStub, although not polished yet, and the slow case always went to the runtime anyway, so we can just directly emit a runtime call there. BUG= Committed: https://crrev.com/ede69c4978be9575ee79cae48766bd707b10d291 Cr-Commit-Position: refs/heads/master@{#34062}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -321 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +4 lines, -16 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 18 chunks +259 lines, -300 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 10 months ago (2016-02-17 07:26:53 UTC) #2
Weiliang
lgtm
4 years, 10 months ago (2016-02-17 09:10:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1701983004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1701983004/1
4 years, 10 months ago (2016-02-17 09:16:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-17 09:35:28 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 09:35:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ede69c4978be9575ee79cae48766bd707b10d291
Cr-Commit-Position: refs/heads/master@{#34062}

Powered by Google App Engine
This is Rietveld 408576698